Retry request if no response is sent by management plane#1381
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1381 +/- ##
==========================================
+ Coverage 86.31% 86.44% +0.13%
==========================================
Files 102 102
Lines 12603 12617 +14
==========================================
+ Hits 10878 10907 +29
+ Misses 1249 1232 -17
- Partials 476 478 +2
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
dhurley
reviewed
Nov 13, 2025
| ) { | ||
| slog.DebugContext(ctx, "Create connection request", "request", request) | ||
|
|
||
| if !cs.firstConnectionCallFlag { |
Collaborator
There was a problem hiding this comment.
Can you add a comment here explaining why we are doing this?
spencerugbo
approved these changes
Nov 20, 2025
dhurley
reviewed
Nov 21, 2025
dhurley
approved these changes
Nov 25, 2025
sean-breen
approved these changes
Nov 25, 2025
craigell
approved these changes
Nov 27, 2025
Akshay2191
pushed a commit
that referenced
this pull request
Dec 18, 2025
Akshay2191
pushed a commit
that referenced
this pull request
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Added
response_timeoutto agent config underclient_grpc-> Default is 10 secondsUse
response_timeoutwhen making request to management plane, if no response is received in the set time resend the response.Modified the mock management plane so the first create connection request is ignored to test the retry logic in the integration tests.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)