POC: POC branch for external file implementation using cloud auth#1462
Closed
Akshay2191 wants to merge 18 commits intoexternal-file-mgmt-integrationfrom
Closed
POC: POC branch for external file implementation using cloud auth#1462Akshay2191 wants to merge 18 commits intoexternal-file-mgmt-integrationfrom
Akshay2191 wants to merge 18 commits intoexternal-file-mgmt-integrationfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## external-file-mgmt-integration #1462 +/- ##
==================================================================
- Coverage 86.31% 85.88% -0.43%
==================================================================
Files 102 102
Lines 12603 12882 +279
==================================================================
+ Hits 10878 11064 +186
- Misses 1249 1333 +84
- Partials 476 485 +9
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
e50d100 to
2e981e0
Compare
Contributor
Author
|
This feature will be done by NGINXSaas team This PR was open as a part of POC to see how much the agent binary will increase if we add all the dependant packages directly to agen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did a POC to see the imports required to add the file fetching and auth features directly in Agent code for 3 cloud providers
AWS,Azure,GCP
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)