Add agent config option to set NGINX API URL and socket path#1485
Add agent config option to set NGINX API URL and socket path#1485
Conversation
|
We've noticed occasional issues with agent finding the NGINX Plus API. Is this an attempt to work around that by being explicit? |
Hi @sjberman this PR is to work around a specific use case where the server block and location block for the NGINX Plus API are in separate NGINX config files. Due to a limitation in the go-crossplane library that we use we can't construct the NGINX Plus API URL when the config is spread across multiple files. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1485 +/- ##
==========================================
+ Coverage 85.22% 85.23% +0.01%
==========================================
Files 102 102
Lines 12992 13060 +68
==========================================
+ Hits 11072 11132 +60
- Misses 1431 1436 +5
- Partials 489 492 +3
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Proposed changes
Example:
Example with socket:
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)