Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1493 +/- ##
==========================================
- Coverage 85.10% 85.08% -0.03%
==========================================
Files 102 102
Lines 12992 13249 +257
==========================================
+ Hits 11057 11273 +216
- Misses 1448 1482 +34
- Partials 487 494 +7
... and 20 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
dhurley
reviewed
Jan 22, 2026
craigell
approved these changes
Jan 27, 2026
dhurley
approved these changes
Jan 28, 2026
sean-breen
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the Agent fails to start in AWS Fargate environments. This occurs because Fargate abstracts the host filesystem, causing traditional container ID retrieval methods—which rely on specific /proc/self/mountinfo formats or the presence of standard Docker files—to return empty values. Without a valid Container ID, the Agent cannot unique identify itself to the NGINX One console and terminates.
As a fix, the Agent now detects the Fargate runtime and utilizes the AWS Metadata Endpoint to reliably retrieve the container ID.