Skip to content

Fix Integration Tests#1523

Merged
aphralG merged 5 commits intoensure-stream-closedfrom
close-stream-after-file-upload
Feb 16, 2026
Merged

Fix Integration Tests#1523
aphralG merged 5 commits intoensure-stream-closedfrom
close-stream-after-file-upload

Conversation

@aphralG
Copy link
Contributor

@aphralG aphralG commented Feb 13, 2026

Proposed changes

  • Fix chunking integration tests, mock management plane now calls SendAndClose()
  • Lint

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@aphralG aphralG requested a review from a team as a code owner February 13, 2026 16:24
@github-actions github-actions bot added bug Something isn't working chore Pull requests for routine tasks labels Feb 13, 2026
@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.91%. Comparing base (6bef50b) to head (b363dc7).
⚠️ Report is 1 commits behind head on ensure-stream-closed.

Additional details and impacted files
@@                   Coverage Diff                    @@
##           ensure-stream-closed    #1523      +/-   ##
========================================================
- Coverage                 85.02%   84.91%   -0.12%     
========================================================
  Files                       103      103              
  Lines                     13588    13588              
========================================================
- Hits                      11553    11538      -15     
- Misses                     1518     1535      +17     
+ Partials                    517      515       -2     
Files with missing lines Coverage Δ
internal/file/file_service_operator.go 77.53% <ø> (ø)

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bef50b...b363dc7. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aphralG aphralG merged commit 7b910ae into ensure-stream-closed Feb 16, 2026
34 checks passed
@aphralG aphralG deleted the close-stream-after-file-upload branch February 16, 2026 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working chore Pull requests for routine tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants