Merged
Conversation
* modify alpine package name: nginx-agent-3.0.0_1234 -> nginx-agent-3.0.0.1234 * protoc-gen update
* update config defaults and format
aphralG
reviewed
Feb 20, 2025
| } | ||
| } | ||
|
|
||
| func (fp *FilePlugin) handleConnectionReset(ctx context.Context, msg *bus.Message) { |
Contributor
There was a problem hiding this comment.
Same as above with the lock just wondering if when it is being reset the connection needs to be locked
dhurley
approved these changes
Feb 25, 2025
aphralG
approved these changes
Feb 25, 2025
aphralG
reviewed
Feb 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
CredentialWatcherServicewhich will initially monitor the file pointed to bytokenpathoption in agent conf.Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)