Skip to content

Remove unsupported from agent v3 install#987

Merged
aphralG merged 3 commits intov3from
update-agent-install
Mar 3, 2025
Merged

Remove unsupported from agent v3 install#987
aphralG merged 3 commits intov3from
update-agent-install

Conversation

@RRashmit
Copy link
Contributor

Proposed changes

Removed the creation of the agent-dynamic.conf file and setting instance-groups
Remove FreeBSD specific commands

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@RRashmit RRashmit added the v3.x Issues and Pull Requests related to the major version v3 label Feb 17, 2025
@RRashmit RRashmit self-assigned this Feb 17, 2025
@RRashmit RRashmit changed the title chore: remove unsupported from agent v3 install Remove unsupported from agent v3 install Feb 17, 2025
@RRashmit
Copy link
Contributor Author

RRashmit commented Feb 18, 2025

Testing:

Verified it working with the modified scripts
image

@RRashmit RRashmit marked this pull request as ready for review February 18, 2025 10:27
@RRashmit RRashmit requested a review from a team as a code owner February 18, 2025 10:27
Copy link
Collaborator

@dhurley dhurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fi
}

upgrade_config_file() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can remove the functions upgrade_config_file and add_default_config_file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default nginx-agent.conf is packaged with the agent so I actually dont know why these functions are here. Its probably for some legacy reasons. I'd say remove them and then test out the default install to make sure things still work.

@RRashmit
Copy link
Contributor Author

Verified and looks good with the latest updates.

@aphralG aphralG merged commit 9a88205 into v3 Mar 3, 2025
20 checks passed
@aphralG aphralG deleted the update-agent-install branch March 3, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v3.x Issues and Pull Requests related to the major version v3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants