Conversation
dhurley
left a comment
There was a problem hiding this comment.
Can you also update https://github.com/nginx/agent/blob/907fd2c1c35b902391803eca4c28a505428dedc7/scripts/packages/postremove.sh by removing the freebsd references?
scripts/packages/postinstall.sh
Outdated
| fi | ||
| } | ||
|
|
||
| upgrade_config_file() { |
There was a problem hiding this comment.
I think you can remove the functions upgrade_config_file and add_default_config_file
There was a problem hiding this comment.
I wonder if these are required for the default nginx-agent.conf case https://github.com/nginx/agent/pull/987/files#diff-d1856bfba76fc7d09934477bd66bb125a1e27e4e994b10ede89246b072ecefbaL12
There was a problem hiding this comment.
The default nginx-agent.conf is packaged with the agent so I actually dont know why these functions are here. Its probably for some legacy reasons. I'd say remove them and then test out the default install to make sure things still work.
|
Verified and looks good with the latest updates. |

Proposed changes
Removed the creation of the agent-dynamic.conf file and setting instance-groups
Remove FreeBSD specific commands
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)