Conversation
dhurley
approved these changes
Feb 25, 2025
|
For the nginx.* metrics involving potential IO with both direction of either RX or TX need to know whether or not bi-directional is involved:
If these are one direction only shouldn't need an attribute like Ideally those metrics would also be consistent with the OTel attribute values and not use the abbreviated form of "RX" or "TX" and instead use "receive" and "transmit". For any of the metric names containing the word "byte", this isn't really something we should use since the Unit (UCUM) describes that. So could go through and revise any that have ".byte" appearing in the name? |
9fac86e to
667e23b
Compare
667e23b to
e7d7fc6
Compare
|
LGTM! |
sean-breen
approved these changes
Feb 28, 2025
craigell
approved these changes
Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
In an effort to be more consistent with the use of "count" and pluralization the following changes were made:
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)