Closed
Conversation
internal/file/file_operator.go
Outdated
Comment on lines
+201
to
+202
| outputFile, createErr := os.Create(destPath) | ||
| if createErr != nil { |
Member
There was a problem hiding this comment.
- we're destroying any file permissions it had when it gets moved. Read from sourcepath and apply to destpath?
- It's often better to create a temp file in the target location and then do a rename once the data is written. This way other processes don't see partially written files at expected locations.
Member
|
For a while now I've been wanting an NGINX with chroot option:
But this would make these tasks so easy to do-- we can prepare the new space, and if it doesn't work there's no trying to copy files back into the right location. I've been thinking maybe we could do this with a eBPF program that intercepts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
rollbackFileContents map[string][]bytewhich was used to rollback files during a failed config applyrollback<some-number>in/var/lib/nginx-agent/Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)