cherry pick to chosen branch #7678
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
github_actions
|
@pdabelf5 Could you make a similar PR in the documentation rep once this has gone through merge/testing/etc? |
AlexFenlon
approved these changes
Apr 23, 2025
nginx-jack
reviewed
Apr 23, 2025
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
| with: | ||
| fetch-depth: 0 | ||
| token: ${{ secrets.NGINX_PAT }} | ||
|
|
||
| - name: Check if Actor is a Member of one of the teams | ||
| uses: im-open/[email protected] |
There was a problem hiding this comment.
We should pin this to a specific commit so dependabot got pickup the updates
nginx-jack
reviewed
Apr 23, 2025
| @@ -15,23 +14,43 @@ jobs: | |||
| pull-requests: write | |||
| runs-on: ubuntu-22.04 | |||
| name: Cherry pick into release branch | |||
| if: ${{ (contains(github.event.pull_request.labels.*.name, 'dependencies') || contains(github.event.pull_request.labels.*.name, 'needs cherry pick')) && github.event.pull_request.merged == true }} | |||
| if: ${{ github.event.issue.pull_request.merged_at != null }} | |||
| steps: | |||
| - name: Checkout | |||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | |||
| with: | |||
| fetch-depth: 0 | |||
| token: ${{ secrets.NGINX_PAT }} | |||
There was a problem hiding this comment.
Is the reason for the NGINX_PAT usage, to allow automatic triggering of downstream actions?
If we cannot use a GITHUB_TOKEN, we'll need to make sure the NGINX_PAT is available in the docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Change cherry-pick logic to be based off comments from authorised users. Only works on already merged PR's. Users can choose which release branch to cherry pick to and can comment for additional release branches as well as the current release branch.
Usage
Checklist
Before creating a PR, run through this checklist and mark each as complete.