Skip to content

Commit fce2d38

Browse files
committed
switch from warning to debug when upstream labels are empty (#724)
1 parent 85fa58b commit fce2d38

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

Diff for: collector/nginx_plus.go

+7-7
Original file line numberDiff line numberDiff line change
@@ -677,7 +677,7 @@ func (c *NginxPlusCollector) Collect(ch chan<- prometheus.Metric) {
677677
varLabelValues := c.getServerZoneLabelValues(name)
678678

679679
if c.variableLabelNames.ServerZoneVariableLabelNames != nil && len(varLabelValues) != len(c.variableLabelNames.ServerZoneVariableLabelNames) {
680-
level.Warn(c.logger).Log("msg", "wrong number of labels for http zone, empty labels will be used instead", "zone", name, "expected", len(c.variableLabelNames.ServerZoneVariableLabelNames), "got", len(varLabelValues))
680+
level.Debug(c.logger).Log("msg", "wrong number of labels for http zone, empty labels will be used instead", "zone", name, "expected", len(c.variableLabelNames.ServerZoneVariableLabelNames), "got", len(varLabelValues))
681681
for range c.variableLabelNames.ServerZoneVariableLabelNames {
682682
labelValues = append(labelValues, "")
683683
}
@@ -798,7 +798,7 @@ func (c *NginxPlusCollector) Collect(ch chan<- prometheus.Metric) {
798798
varLabelValues := c.getStreamServerZoneLabelValues(name)
799799

800800
if c.variableLabelNames.StreamServerZoneVariableLabelNames != nil && len(varLabelValues) != len(c.variableLabelNames.StreamServerZoneVariableLabelNames) {
801-
level.Warn(c.logger).Log("msg", "wrong number of labels for stream server zone, empty labels will be used instead", "zone", name, "expected", len(c.variableLabelNames.StreamServerZoneVariableLabelNames), "got", len(varLabelValues))
801+
level.Debug(c.logger).Log("msg", "wrong number of labels for stream server zone, empty labels will be used instead", "zone", name, "expected", len(c.variableLabelNames.StreamServerZoneVariableLabelNames), "got", len(varLabelValues))
802802
for range c.variableLabelNames.StreamServerZoneVariableLabelNames {
803803
labelValues = append(labelValues, "")
804804
}
@@ -835,7 +835,7 @@ func (c *NginxPlusCollector) Collect(ch chan<- prometheus.Metric) {
835835
varLabelValues := c.getUpstreamServerLabelValues(name)
836836

837837
if c.variableLabelNames.UpstreamServerVariableLabelNames != nil && len(varLabelValues) != len(c.variableLabelNames.UpstreamServerVariableLabelNames) {
838-
level.Warn(c.logger).Log("msg", "wrong number of labels for upstream, empty labels will be used instead", "upstream", name, "expected", len(c.variableLabelNames.UpstreamServerVariableLabelNames), "got", len(varLabelValues))
838+
level.Debug(c.logger).Log("msg", "wrong number of labels for upstream, empty labels will be used instead", "upstream", name, "expected", len(c.variableLabelNames.UpstreamServerVariableLabelNames), "got", len(varLabelValues))
839839
for range c.variableLabelNames.UpstreamServerVariableLabelNames {
840840
labelValues = append(labelValues, "")
841841
}
@@ -846,7 +846,7 @@ func (c *NginxPlusCollector) Collect(ch chan<- prometheus.Metric) {
846846
upstreamServer := fmt.Sprintf("%v/%v", name, peer.Server)
847847
varPeerLabelValues := c.getUpstreamServerPeerLabelValues(upstreamServer)
848848
if c.variableLabelNames.UpstreamServerPeerVariableLabelNames != nil && len(varPeerLabelValues) != len(c.variableLabelNames.UpstreamServerPeerVariableLabelNames) {
849-
level.Warn(c.logger).Log("msg", "wrong number of labels for upstream peer, empty labels will be used instead", "upstream", name, "peer", peer.Server, "expected", len(c.variableLabelNames.UpstreamServerPeerVariableLabelNames), "got", len(varPeerLabelValues))
849+
level.Debug(c.logger).Log("msg", "wrong number of labels for upstream peer, empty labels will be used instead", "upstream", name, "peer", peer.Server, "expected", len(c.variableLabelNames.UpstreamServerPeerVariableLabelNames), "got", len(varPeerLabelValues))
850850
for range c.variableLabelNames.UpstreamServerPeerVariableLabelNames {
851851
labelValues = append(labelValues, "")
852852
}
@@ -992,7 +992,7 @@ func (c *NginxPlusCollector) Collect(ch chan<- prometheus.Metric) {
992992
varLabelValues := c.getStreamUpstreamServerLabelValues(name)
993993

994994
if c.variableLabelNames.StreamUpstreamServerVariableLabelNames != nil && len(varLabelValues) != len(c.variableLabelNames.StreamUpstreamServerVariableLabelNames) {
995-
level.Warn(c.logger).Log("msg", "wrong number of labels for stream server, empty labels will be used instead", "server", name, "labels", c.variableLabelNames.StreamUpstreamServerVariableLabelNames, "values", varLabelValues)
995+
level.Debug(c.logger).Log("msg", "wrong number of labels for stream server, empty labels will be used instead", "server", name, "labels", c.variableLabelNames.StreamUpstreamServerVariableLabelNames, "values", varLabelValues)
996996
for range c.variableLabelNames.StreamUpstreamServerVariableLabelNames {
997997
labelValues = append(labelValues, "")
998998
}
@@ -1003,7 +1003,7 @@ func (c *NginxPlusCollector) Collect(ch chan<- prometheus.Metric) {
10031003
upstreamServer := fmt.Sprintf("%v/%v", name, peer.Server)
10041004
varPeerLabelValues := c.getStreamUpstreamServerPeerLabelValues(upstreamServer)
10051005
if c.variableLabelNames.StreamUpstreamServerPeerVariableLabelNames != nil && len(varPeerLabelValues) != len(c.variableLabelNames.StreamUpstreamServerPeerVariableLabelNames) {
1006-
level.Warn(c.logger).Log("msg", "wrong number of labels for stream upstream peer, empty labels will be used instead", "server", upstreamServer, "labels", c.variableLabelNames.StreamUpstreamServerPeerVariableLabelNames, "values", varPeerLabelValues)
1006+
level.Debug(c.logger).Log("msg", "wrong number of labels for stream upstream peer, empty labels will be used instead", "server", upstreamServer, "labels", c.variableLabelNames.StreamUpstreamServerPeerVariableLabelNames, "values", varPeerLabelValues)
10071007
for range c.variableLabelNames.StreamUpstreamServerPeerVariableLabelNames {
10081008
labelValues = append(labelValues, "")
10091009
}
@@ -1255,7 +1255,7 @@ func (c *NginxPlusCollector) Collect(ch chan<- prometheus.Metric) {
12551255
varLabelValues := c.getWorkerLabelValues(strconv.FormatInt(int64(worker.ID), 10))
12561256

12571257
if c.variableLabelNames.WorkerPIDVariableLabelNames != nil && len(varLabelValues) != len(c.variableLabelNames.WorkerPIDVariableLabelNames) {
1258-
level.Warn(c.logger).Log("wrong number of labels for worker %v. For labels %v, got values: %v. Empty labels will be used instead",
1258+
level.Debug(c.logger).Log("wrong number of labels for worker %v. For labels %v, got values: %v. Empty labels will be used instead",
12591259
strconv.FormatInt(int64(worker.ID), 10), c.variableLabelNames.WorkerPIDVariableLabelNames, varLabelValues)
12601260
for range c.variableLabelNames.WorkerPIDVariableLabelNames {
12611261
labelValues = append(labelValues, "")

0 commit comments

Comments
 (0)