fix linting errors

Author: xynicole

build.go

@@ -108,6 +108,7 @@ func Build(w io.Writer, config Config, options *BuildOptions) error {
 	return err
 }
 
+//nolint:funlen,gocognit
 func buildBlock(sb io.StringWriter, parent *Directive, block Directives, depth int, lastLine int, options *BuildOptions) {
 	for i, stmt := range block {
 		// if the this statement is a comment on the same line as the preview, do not emit EOL for this stmt
@@ -131,19 +132,21 @@ func buildBlock(sb io.StringWriter, parent *Directive, block Directives, depth i
 			directive := Enquote(stmt.Directive)
 			_, _ = sb.WriteString(directive)
 
+			switch {
 			// special handling for'set_by_lua_block' directive
-			if directive == "set_by_lua_block" {
+			case directive == "set_by_lua_block":
 				_, _ = sb.WriteString(" ")
 				_, _ = sb.WriteString(stmt.Args[0]) // argument for return value
 				_, _ = sb.WriteString(" {")
 				_, _ = sb.WriteString(stmt.Args[1]) // argument containing block content
 				_, _ = sb.WriteString("}")
 				// handling other lua block directives
-			} else if strings.Contains(directive, "_by_lua_block") {
+			case strings.Contains(directive, "_by_lua_block"):
 				_, _ = sb.WriteString(" {")
 				_, _ = sb.WriteString(stmt.Args[0])
 				_, _ = sb.WriteString("}")
-			} else {
+
+			default:
 				// special handling for if statements
 				if directive == "if" {
 					_, _ = sb.WriteString(" (")

build_test.go

@@ -35,7 +35,7 @@ type compareFixture struct {
 	options ParseOptions
 }
 
-//nolint:gochecknoglobals, goconst
+//nolint:gochecknoglobals
 var buildFixtures = []buildFixture{
 	{
 		name:    "nested-and-multiple-args",

lex.go

@@ -52,7 +52,7 @@ type LexScanner interface {
 }
 
 type ExtLexer interface {
-	Register(LexScanner) []string
+	Register(scanner LexScanner) []string
 	Lex(matchedToken string) <-chan NgxToken
 }
 
@@ -93,7 +93,7 @@ type tokenInfo struct {
 	LineNumberExists bool
 }
 
-//nolint:gocyclo,funlen,gocognit
+//nolint:gocyclo,funlen,gocognit,maintidx
 func tokenize(reader io.Reader, tokenCh chan NgxToken, options LexOptions) {
 	token := strings.Builder{}
 	tokenLine := 1
@@ -164,6 +164,7 @@ func tokenize(reader io.Reader, tokenCh chan NgxToken, options LexOptions) {
 			la = "\\" + la
 		}
 
+		// special handling for *_by_lua_block directives
 		if token.Len() > 0 {
 			tokenStr := token.String()
 			if ext, ok := externalLexers[tokenStr]; ok {
@@ -187,7 +188,6 @@ func tokenize(reader io.Reader, tokenCh chan NgxToken, options LexOptions) {
 					if lastLexState == inQuote && la == quote {
 						continue
 					}
-
 				}
 			}
 		}
@@ -345,7 +345,7 @@ func (ll *LuaLexer) Register(s LexScanner) []string {
 	}
 }
 
-//nolint:funlen
+//nolint:funlen,gocognit,gocyclo
 func (ll *LuaLexer) Lex(matchedToken string) <-chan NgxToken {
 	tokenCh := make(chan NgxToken)
 
@@ -356,6 +356,7 @@ func (ll *LuaLexer) Lex(matchedToken string) <-chan NgxToken {
 		var tok strings.Builder
 		var inQuotes bool
 
+		// special handling for'set_by_lua_block' directive
 		if matchedToken == "set_by_lua_block" {
 			arg := ""
 			for {
@@ -407,7 +408,6 @@ func (ll *LuaLexer) Lex(matchedToken string) <-chan NgxToken {
 			if err := ll.s.Err(); err != nil {
 				lineno := ll.s.Line()
 				tokenCh <- NgxToken{Error: &ParseError{File: &lexerFile, What: err.Error(), Line: &lineno}}
-
 			}
 
 			switch {
@@ -431,7 +431,7 @@ func (ll *LuaLexer) Lex(matchedToken string) <-chan NgxToken {
 
 				if tokenDepth == 0 {
 					tokenCh <- NgxToken{Value: tok.String(), Line: ll.s.Line(), IsQuoted: true}
-					tokenCh <- NgxToken{Value: ";", Line: ll.s.Line(), IsQuoted: false} // For an end to the Lua string, seems hacky.
+					tokenCh <- NgxToken{Value: ";", Line: ll.s.Line(), IsQuoted: false} // For an end to the Lua string based on the nginx bahavior
 					// See: https://github.com/nginxinc/crossplane/blob/master/crossplane/ext/lua.py#L122C25-L122C41
 					return
 				}
@@ -442,8 +442,7 @@ func (ll *LuaLexer) Lex(matchedToken string) <-chan NgxToken {
 
 			default:
 				// Expected first token encountered to be a "{" to open a Lua block. Handle any other non-whitespace
-				// character to mean we are not about to tokenize Lua.
-
+				// character to mean we are not about to tokenize Lua
 				// ignoring everything until first open brace where tokenDepth > 0
 				if isSpace(next) && tokenDepth == 0 {
 					continue

lex_test.go

@@ -8,8 +8,6 @@
 package crossplane
 
 import (
-	"encoding/json"
-	"io"
 	"os"
 	"strings"
 	"testing"
@@ -482,60 +480,3 @@ func TestLex_unhappy(t *testing.T) {
 		})
 	}
 }
-
-func TestLex_lua(t *testing.T) {
-	t.Parallel()
-
-	r := strings.NewReader(`http {
-		server {
-			location / {
-				content_by_lua_block {
-					ngx.say('Hello, world!')
-				}
-				return 200, "OK";
-			}
-			listen 8080; # check that lua hasn't messed up context/depth and lineno
-		}
-	}`)
-
-	options := LexOptions{
-		ExternalLexers: []ExtLexer{
-			&LuaLexer{},
-		},
-	}
-
-	for tok := range LexWithOptions(r, options) {
-		t.Logf("{%q, %d}", tok.Value, tok.Line)
-	}
-}
-
-func TestParse_lua(t *testing.T) {
-	t.Parallel()
-
-	r := strings.NewReader(`http {
-		server {
-			location / {
-				content_by_lua_block {
-					ngx.say('Hello, world!')
-				}
-				return 200, "OK";
-			}
-			listen 8080; # check that lua hasn't messed up context/depth and lineno
-		}
-	}`)
-
-	payload, err := Parse("nginx.conf", &ParseOptions{
-		Open: func(path string) (io.Reader, error) { return r, nil },
-		LexOptions: LexOptions{
-			ExternalLexers: []ExtLexer{
-				&LuaLexer{},
-			},
-		},
-	})
-	if err != nil {
-		t.Fatal(err)
-	}
-
-	b, _ := json.MarshalIndent(payload, "", "  ")
-	t.Log(string(b))
-}