Skip to content

Commit 19963f8

Browse files
committed
Remove id_size test as senseless.
1 parent 3cc6a68 commit 19963f8

File tree

1 file changed

+5
-20
lines changed

1 file changed

+5
-20
lines changed

tests/test_otel.py

Lines changed: 5 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -222,16 +222,10 @@ def response(logger, http_ver, otel_mode, url, headers):
222222
({"port": 8317, "name": "test_http3", "mode": "quic"}, 3, 1),
223223
],
224224
indirect=["nginx_config"],
225-
ids=[
226-
"https 0.9-to mock",
227-
"https 0.9-to otelcol",
228-
"https-to mock",
229-
"https-to otelcol",
230-
"http2-to mock",
231-
"http2-to otelcol",
232-
"quic-to mock",
233-
"quic-to otelcol",
234-
],
225+
ids=["https 0.9-to mock", "https 0.9-to otelcol"]
226+
+ ["https-to mock", "https-to otelcol"]
227+
+ ["http2-to mock", "http2-to otelcol"]
228+
+ ["quic-to mock", "quic-to otelcol"],
235229
scope="module",
236230
)
237231
class TestOTelGenerateSpans:
@@ -287,15 +281,6 @@ def test_service_name(self, http_ver, batches, idx, otel_mode):
287281
== f"test_http{http_ver}"
288282
)
289283

290-
@pytest.mark.parametrize("idx", range(30), ids=["span"] * 30)
291-
@pytest.mark.parametrize(
292-
("name", "value"),
293-
[("trace_id", 16), ("span_id", 8)],
294-
ids=["trace_id", "span_id"],
295-
)
296-
def test_id_size(self, http_ver, span, idx, name, value, otel_mode):
297-
assert len(getattr(span, name)) == value
298-
299284
@pytest.mark.parametrize(
300285
("idx", "value"),
301286
enumerate(
@@ -503,7 +488,7 @@ def test_no_variables(self, http_ver, headers, name, value, idx, otel_mode):
503488
[
504489
(
505490
"X-Otel-Parent-Id",
506-
[None] * 3 + [span_id] + [None] * 3 + [span_id],
491+
([None] * 3 + [span_id]) * 2,
507492
),
508493
(
509494
"X-Otel-Traceparent",

0 commit comments

Comments
 (0)