Skip to content

Commit 3de3014

Browse files
committed
Return certificates by certs fixture.
1 parent 67068ff commit 3de3014

File tree

2 files changed

+6
-9
lines changed

2 files changed

+6
-9
lines changed

tests/conftest.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,10 @@ def self_signed_cert(test_dir, name):
3535
(test_dir / f"{name}.crt").write_text(
3636
crypto.dump_certificate(crypto.FILETYPE_PEM, cert).decode("utf-8")
3737
)
38+
return (
39+
crypto.dump_privatekey(crypto.FILETYPE_PEM, k),
40+
crypto.dump_certificate(crypto.FILETYPE_PEM, cert),
41+
)
3842

3943

4044
@pytest.fixture(scope="session")
@@ -97,4 +101,4 @@ def nginx(testdir, pytestconfig, nginx_config, certs, logger, otelcol):
97101

98102
@pytest.fixture(scope="module")
99103
def certs(testdir):
100-
self_signed_cert(testdir, "localhost")
104+
yield self_signed_cert(testdir, "localhost")

tests/trace_service.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -45,14 +45,7 @@ def trace_service(request, pytestconfig, testdir, logger, certs):
4545
listen_addr = f"127.0.0.1:{24317 if trace_service.use_otelcol else 14317}"
4646
server.add_insecure_port(listen_addr)
4747
if pytestconfig.option.otelcol is None:
48-
creds = grpc.ssl_server_credentials(
49-
[
50-
(
51-
(testdir / "localhost.key").read_text().encode(),
52-
(testdir / "localhost.crt").read_text().encode(),
53-
)
54-
]
55-
)
48+
creds = grpc.ssl_server_credentials([certs])
5649
server.add_secure_port("127.0.0.1:14318", creds)
5750
listen_addr += " and 127.0.0.1:14318"
5851
logger.info(f"Starting trace service at {listen_addr}...")

0 commit comments

Comments
 (0)