Skip to content

Commit f12499b

Browse files
committed
Unify names of some tests and variables.
1 parent 13231b0 commit f12499b

File tree

1 file changed

+20
-33
lines changed

1 file changed

+20
-33
lines changed

tests/test_otel.py

Lines changed: 20 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,7 @@ def teardown_class(cls):
240240
time.sleep(3) # wait for sending the last batch to collector
241241

242242
@pytest.mark.parametrize(
243-
"headers", [None, context], ids=["no context", "with context"]
243+
"headers", [None, context], ids=["no context", "context"]
244244
)
245245
@pytest.mark.parametrize(
246246
("url", "text"),
@@ -275,10 +275,10 @@ def test_do_request(
275275
@pytest.mark.parametrize("otel_mode", [0, 1], ids=["to mock", "to otelcol"])
276276
class TestOTelSpans:
277277
@pytest.mark.parametrize(
278-
("idx", "size"), [(0, 10), (1, 10), (2, 10)], ids=["batch"] * 3
278+
("idx", "value"), [(0, 10), (1, 10), (2, 10)], ids=["batch"] * 3
279279
)
280-
def test_batch_size(self, http_ver, batches, idx, size, otel_mode):
281-
assert len(batches[idx][0].scope_spans[0].spans) == size
280+
def test_batch_size(self, http_ver, batches, idx, value, otel_mode):
281+
assert len(batches[idx][0].scope_spans[0].spans) == value
282282

283283
@pytest.mark.parametrize("idx", [0, 1, 2], ids=["batch"] * 3)
284284
def test_service_name(self, http_ver, batches, idx, otel_mode):
@@ -289,40 +289,27 @@ def test_service_name(self, http_ver, batches, idx, otel_mode):
289289

290290
@pytest.mark.parametrize("idx", range(30), ids=["span"] * 30)
291291
@pytest.mark.parametrize(
292-
("name", "size"),
292+
("name", "value"),
293293
[("trace_id", 16), ("span_id", 8)],
294294
ids=["trace_id", "span_id"],
295295
)
296-
def test_id_size(self, http_ver, span, idx, name, size, otel_mode):
297-
assert len(getattr(span, name)) == size
296+
def test_id_size(self, http_ver, span, idx, name, value, otel_mode):
297+
assert len(getattr(span, name)) == value
298298

299299
@pytest.mark.parametrize(
300-
("idx", "name"),
301-
[
302-
(i, n)
303-
for (i, n) in enumerate(
304-
["default_location"] * 2
305-
+ ["context_ignore"] * 2
306-
+ ["context_extract"] * 2
307-
+ ["context_inject"] * 2
308-
+ ["context_propagate"] * 2
309-
+ ["default_location"] * 20
310-
)
311-
],
312-
ids=[
313-
f"{v}-span{i}"
314-
for (i, v) in enumerate(
315-
["default_location"] * 2
316-
+ ["context_ignore"] * 2
317-
+ ["context_extract"] * 2
318-
+ ["context_inject"] * 2
319-
+ ["context_propagate"] * 2
320-
+ ["default_location"] * 20
321-
)
322-
],
300+
("idx", "value"),
301+
enumerate(
302+
["default_location"] * 2
303+
+ ["context_ignore"] * 2
304+
+ ["context_extract"] * 2
305+
+ ["context_inject"] * 2
306+
+ ["context_propagate"] * 2
307+
+ ["default_location"] * 20
308+
),
309+
ids=["span"] * 30,
323310
)
324-
def test_span_name(self, http_ver, span, name, idx, otel_mode):
325-
assert span.name == name
311+
def test_span_name(self, http_ver, span, value, idx, otel_mode):
312+
assert span.name == value
326313

327314
@pytest.mark.parametrize("idx", range(30), ids=["span"] * 30)
328315
@pytest.mark.parametrize(
@@ -400,7 +387,7 @@ def test_metrics(self, http_ver, span, idx, name, atype, value, otel_mode):
400387

401388
@pytest.mark.parametrize(
402389
"idx",
403-
[0, 1] + [i for i in range(10, 30)],
390+
[0, 1] + list(range(10, 30)),
404391
ids=["span"] * 2 + [f"span{i}" for i in range(10, 30)],
405392
)
406393
@pytest.mark.parametrize(

0 commit comments

Comments
 (0)