trackRequestResult - not responding when using take(1) within the pipe

[haythem-ouederni]

Which @ngneat/elf-* package(s) are the source of the bug?

Don't known / other

Is this a regression?

No

Description

Hello,
When trackRequestResult with a take(1) some after in the pipe, the second time we call the pipe containing all of it no result is returned.

Here is a example of the structure of a method calling trackRequestResult:

myFunction(): Observable<string> {
    return of(void 0).pipe(
      mergeMap(() => // any call to a webservice for eample),
     tap((resultFromWs) => // update the elf store with the result),
     trackRequestResult([uniqueID], {cacheResponseData: true}),
     mergeMap(() => // return the result from the store)
  )
}

And somewhere else in the code we call myFunction() as follow:

myFunction().pipe(take(1)).subscribe(() => {
   // do things
})

When myFunction is called for the first time we have the result returned. But after the first call, and from anywhere in the code, nothing happens.

If have quickly taken a look at the code source of trackRequestResult and I think that is comes from the use of complete within the tap. It is known that the complete is not called when the observable is "unsubscribed".

This is very unfortunate since the functionality is very helpful.

Do you think is it possible to replace the complete with a finalize that should resolve the problem ?

Thanks

Please provide a link to a minimal reproduction of the bug

No response

Please provide the exception or error you saw

Please provide the environment you discovered this bug in

angular 17

"@ngneat/elf": "^2.5.1",
"@ngneat/elf-cli-ng": "^1.0.0",
"@ngneat/elf-devtools": "^1.3.0",
"@ngneat/elf-entities": "^4.5.0",
"@ngneat/elf-requests": "^1.9.2",

Anything else?

No response

Do you want to create a pull request?

No

[javierFerFer]

Hi @haythem-ouederni I was checking ur code and it's correct, it's happening, I don't have enough time to review this more deeper, but I thought that maybe u are using it in the wrong way, if u read the documentation: https://ngneat.github.io/elf/docs/features/requests-result/ u will see that it's thought to be used as part of the configuration as pipes leves that going to populate the store.

Could you check if, following the property docu, u can use it?

[haythem-ouederni]

Hello,
Yes it is correctly used. At the same time nothing, in the documentation, suggests a contraindication against it's use within a pipe et it is difficult to control how developers may integrate it.

[haythem-ouederni]

for those who face the same problem, a work around is to use the rxjs' last operator as follow:

myFunction(): Observable<string> {
    return of(void 0).pipe(
      mergeMap(() => // any call to a webservice for example),
     tap((resultFromWs) => // update the elf store with the result),
     trackRequestResult([uniqueID], {cacheResponseData: true}),
     defualtIfEmpty(// a de fault value), // very important to make the sure the pipe is not broken
     last(), // makes sure that the rest of pipeline executes only after the complete of the input observable source
     mergeMap(() => // return the result from the store)
  )
}

Important: This solution works only thanks to the fact that the observable flow coming before the trackRequestResult completes in all the cases I handle else last() will never fire.