-
-
Notifications
You must be signed in to change notification settings - Fork 188
Open
Description
Is this a regression?
Yes
Description
Using nested arrays in providers overrides breaks factory:
@Injectable()
class MyService {}
describe('MyService', () => {
const createService = createServiceFactory({
service: MyService,
providers: [],
});
it('should create', () => {
const spec = createService({
providers: [[]],
});
expect(spec.service).toBeTruthy();
});
});Angular supports nested provider arrays so I would expect Spectator to do as well.
At a minimum provide a better error description.
Please provide a link to a minimal reproduction of the bug
No response
Please provide the exception or error you saw
FAIL temp.spec.ts
MyService
✕ should create (6 ms)
● MyService › should create
TypeError: Cannot read properties of undefined (reading 'hasOwnProperty')
12 |
13 | it('should create', () => {
> 14 | const spec = createService({
| ^
15 | providers: [[]],
16 | });
17 | expect(spec.service).toBeTruthy();
at getOwnDefinition (../../node_modules/.pnpm/@angular+core@20.1.6_@angular+compiler@20.1.6_rxjs@7.8.2_zone.js@0.15.1/node_modules/@angular/core/fesm2022/root_effect_scheduler.mjs:452:18)
at getInjectableDef (../../node_modules/.pnpm/@angular+core@20.1.6_@angular+compiler@20.1.6_rxjs@7.8.2_zone.js@0.15.1/node_modules/@angular/core/fesm2022/root_effect_scheduler.mjs:441:12)
at TestBedCompiler.overrideProvider (../../node_modules/.pnpm/@angular+core@20.1.6_@angular+compiler@20.1.6_rxjs@7.8.2_zone.js@0.15.1/node_modules/@angular/core/fesm2022/testing.mjs:923:59)
at _TestBedImpl.overrideProvider (../../node_modules/.pnpm/@angular+core@20.1.6_@angular+compiler@20.1.6_rxjs@7.8.2_zone.js@0.15.1/node_modules/@angular/core/fesm2022/testing.mjs:2026:23)
at Function.overrideProvider (../../node_modules/.pnpm/@angular+core@20.1.6_@angular+compiler@20.1.6_rxjs@7.8.2_zone.js@0.15.1/node_modules/@angular/core/fesm2022/testing.mjs:1824:37)
at ../../node_modules/.pnpm/@ngneat+spectator@21.0.1_@angular+animations@20.1.6_@angular+common@20.1.6_@angular+core@20.1_55z53yumeqcaacp7r2w2sovixq/node_modules/@ngneat/spectator/fesm2022/ngneat-spectator.mjs:1949:25
at Array.forEach (<anonymous>)
at ../../node_modules/.pnpm/@ngneat+spectator@21.0.1_@angular+animations@20.1.6_@angular+common@20.1.6_@angular+core@20.1_55z53yumeqcaacp7r2w2sovixq/node_modules/@ngneat/spectator/fesm2022/ngneat-spectator.mjs:1948:23
at src/lib/micro-frontends/temp.spec.ts:14:18
at _ZoneDelegate.invoke (../../node_modules/.pnpm/zone.js@0.15.1/node_modules/zone.js/bundles/zone.umd.js:410:32)
at ProxyZoneSpec.Object.<anonymous>.ProxyZoneSpec.onInvoke (../../node_modules/.pnpm/zone.js@0.15.1/node_modules/zone.js/bundles/zone-testing.umd.js:2219:43)
at _ZoneDelegate.invoke (../../node_modules/.pnpm/zone.js@0.15.1/node_modules/zone.js/bundles/zone.umd.js:409:38)
at ZoneImpl.run (../../node_modules/.pnpm/zone.js@0.15.1/node_modules/zone.js/bundles/zone.umd.js:145:47)
at Object.wrappedFunc (../../node_modules/.pnpm/zone.js@0.15.1/node_modules/zone.js/bundles/zone-testing.umd.js:449:38)
Test Suites: 1 failed, 1 total
Tests: 1 failed, 1 total
Snapshots: 0 total
Time: 2.259 s
Please provide the environment you discovered this bug in
Anything else?
No response
Do you want to create a pull request?
No
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels