Remove the deprecated cloud endpoint domain status (#727)

Author: alex-bezek

api/ngrok/v1alpha1/cloudendpoint_types.go

@@ -25,7 +25,6 @@ SOFTWARE.
 package v1alpha1
 
 import (
-	ingressv1alpha1 "github.com/ngrok/ngrok-operator/api/ingress/v1alpha1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 )
 
@@ -89,10 +88,6 @@ type CloudEndpointStatus struct {
 	// ID is the unique identifier for this endpoint
 	ID string `json:"id,omitempty"`
 
-	// Deprecated: This is here for backwards compatibility with the old DomainStatus object.
-	// This will be removed in a future version. Use DomainRef instead.
-	Domain *CloudEndpointStatusDeprecatedDomainStatus `json:"domain,omitempty"`
-
 	// DomainRef is a reference to the Domain resource associated with this endpoint.
 	// For internal endpoints, this will be nil.
 	// +kubebuilder:validation:Optional
@@ -108,31 +103,6 @@ type CloudEndpointStatus struct {
 	Conditions []metav1.Condition `json:"conditions,omitempty"`
 }
 
-// Deprecated: This is here for backwards compatibility with the old DomainStatus object.
-// This will be removed in a future version.
-type CloudEndpointStatusDeprecatedDomainStatus struct {
-	// ID is the unique identifier of the domain
-	ID string `json:"id,omitempty"`
-
-	// Domain is the domain that was reserved
-	Domain string `json:"domain,omitempty"`
-
-	// Region is the region in which the domain was created
-	Region string `json:"region,omitempty"`
-
-	// CNAMETarget is the CNAME target for the domain
-	CNAMETarget *string `json:"cnameTarget,omitempty"`
-}
-
-func ConvertDomainStatusToDeprecatedDomainStatus(domain *ingressv1alpha1.DomainStatus) *CloudEndpointStatusDeprecatedDomainStatus {
-	return &CloudEndpointStatusDeprecatedDomainStatus{
-		ID:          domain.ID,
-		Domain:      domain.Domain,
-		Region:      domain.Region,
-		CNAMETarget: domain.CNAMETarget,
-	}
-}
-
 // CloudEndpoint is the Schema for the cloudendpoints API
 //
 // +kubebuilder:object:root=true

api/ngrok/v1alpha1/zz_generated.deepcopy.go

@@ -256,13 +256,6 @@ func (r *CloudEndpointReconciler) updateStatus(ctx context.Context, clep *ngrokv
 		clep.Status.ID = ngrokClep.ID
 	}
 
-	// Update domain status fields
-	if domainResult != nil && domainResult.Domain != nil {
-		// Set the deprecated domain status for backwards compatibility
-		//nolint:staticcheck
-		clep.Status.Domain = ngrokv1alpha1.ConvertDomainStatusToDeprecatedDomainStatus(&domainResult.Domain.Status)
-	}
-
 	// Calculate overall Ready condition based on other conditions and domain status
 	calculateCloudEndpointReadyCondition(clep, domainResult)