Skip to content

feat(component-store): resubscribe on errors #3963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

e-oz
Copy link
Contributor

@e-oz e-oz commented Jul 19, 2023

When function passed to effect() throws an error, or a value passed to effect() throws an error - resubscribe using retry().

Closes #3962

PR Checklist

Please check if your PR fulfills the following requirements:

I'm ready to modify the documentation if RFC will be approved.

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

When function passed to `effect()` throws an error, or a value passed to `effect()` throws an error - resubscribe using `retry()`.

Closes ngrx#3962
@netlify
Copy link

netlify bot commented Jul 19, 2023

Deploy Preview for ngrx-io canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit e277b84
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/64b82c259d0f2a00082af770

@e-oz
Copy link
Contributor Author

e-oz commented Jul 19, 2023

When I run yarn test all tests pass.

@markostanimirovic
Copy link
Member

I'll close this PR for now because it would introduce a breaking change and cannot be merged in v16.

Opened RFC will be considered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: Resubscribe on errors in ComponentStore.effect()
2 participants