Skip to content

Commit 3c9b3b1

Browse files
authored
fix: manually set @angular/platform-browser as optional peerDependency (#174)
## PR Checklist Please check if your PR fulfills the following requirements: - [x] The commit message follows our guidelines: CONTRIBUTING.md#commit - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> ``` [ ] Bugfix [ ] Feature [ ] Code style update (formatting, local variables) [ ] Refactoring (no functional changes, no api changes) [x] Build related changes [ ] CI related changes [ ] Documentation content changes [ ] Other... Please describe: ``` ## What is the current behavior? `@angular/platform-browser` is being added automatically as a peer dependency to the package.json on the build but is not treated manually. Closes: #170 ## What is the new behavior? We manually set `@angular/platform-browser` as an optional peerDependency on the package.json. ## Does this PR introduce a breaking change? ``` [ ] Yes [x] No ```
1 parent 9c7581b commit 3c9b3b1

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

packages/ngworker/lumberjack/package.json

+4
Original file line numberDiff line numberDiff line change
@@ -39,12 +39,16 @@
3939
"peerDependencies": {
4040
"@angular/core": ">= 15.0.1",
4141
"@angular/common": ">= 15.0.1",
42+
"@angular/platform-browser": ">= 15.0.1",
4243
"rxjs": "~7.5.0"
4344
},
4445
"peerDependenciesMeta": {
4546
"@angular/common": {
4647
"optional": true
4748
},
49+
"@angular/platform-browser": {
50+
"optional": true
51+
},
4852
"rxjs": {
4953
"optional": true
5054
}

packages/ngworker/lumberjack/project.json

-1
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,6 @@
109109
"executor": "ngx-deploy-npm:deploy",
110110
"options": {
111111
"access": "public",
112-
"tag": "next",
113112
"distFolderPath": "dist/packages/ngworker/lumberjack"
114113
}
115114
}

0 commit comments

Comments
 (0)