Skip to content

Commit

Permalink
fix: manually set @angular/platform-browser as optional peerDependency (
Browse files Browse the repository at this point in the history
#174)

## PR Checklist

Please check if your PR fulfills the following requirements:

- [x] The commit message follows our guidelines: CONTRIBUTING.md#commit
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)

## PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

```
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:
```

## What is the current behavior?

`@angular/platform-browser` is being added automatically as a peer
dependency to the package.json on the build but is not treated manually.

Closes: #170 

## What is the new behavior?

We manually set `@angular/platform-browser` as an optional
peerDependency on the package.json.

## Does this PR introduce a breaking change?

```
[ ] Yes
[x] No
```
  • Loading branch information
NachoVazquez authored Aug 16, 2023
1 parent 9c7581b commit 3c9b3b1
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
4 changes: 4 additions & 0 deletions packages/ngworker/lumberjack/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,16 @@
"peerDependencies": {
"@angular/core": ">= 15.0.1",
"@angular/common": ">= 15.0.1",
"@angular/platform-browser": ">= 15.0.1",
"rxjs": "~7.5.0"
},
"peerDependenciesMeta": {
"@angular/common": {
"optional": true
},
"@angular/platform-browser": {
"optional": true
},
"rxjs": {
"optional": true
}
Expand Down
1 change: 0 additions & 1 deletion packages/ngworker/lumberjack/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,6 @@
"executor": "ngx-deploy-npm:deploy",
"options": {
"access": "public",
"tag": "next",
"distFolderPath": "dist/packages/ngworker/lumberjack"
}
}
Expand Down

0 comments on commit 3c9b3b1

Please sign in to comment.