Commit 95e7869
committed
fix: resolve test warnings and update CI to use pnpm
- Add @Injectable() to TestableTranslateService in http-loader to fix
Angular DI deprecation warning
- Fix fakeAsync test in translate.pipe-standalone.spec.ts that was
returning the function instead of executing it
- Add expect() assertions to onTranslationRefresh tests that only had
done() callbacks
- Update GitHub Actions to use pnpm instead of npm (matching project's
packageManager setting)
- Add lint step to CI pipeline1 parent 921d1f0 commit 95e7869
File tree
4 files changed
+25
-17
lines changed- .github/workflows
- projects
- http-loader/src/test-helper
- ngx-translate/src/tests
4 files changed
+25
-17
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
| 18 | + | |
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| 22 | + | |
| 23 | + | |
22 | 24 | | |
23 | 25 | | |
24 | 26 | | |
25 | 27 | | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
10 | 11 | | |
11 | 12 | | |
12 | 13 | | |
| |||
Lines changed: 11 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
58 | | - | |
59 | | - | |
60 | | - | |
| 58 | + | |
| 59 | + | |
61 | 60 | | |
62 | | - | |
63 | | - | |
| 61 | + | |
| 62 | + | |
64 | 63 | | |
65 | | - | |
66 | | - | |
67 | | - | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
68 | 67 | | |
69 | | - | |
70 | | - | |
71 | | - | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
72 | 72 | | |
73 | 73 | | |
Lines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1566 | 1566 | | |
1567 | 1567 | | |
1568 | 1568 | | |
| 1569 | + | |
1569 | 1570 | | |
1570 | 1571 | | |
1571 | 1572 | | |
| |||
1577 | 1578 | | |
1578 | 1579 | | |
1579 | 1580 | | |
| 1581 | + | |
1580 | 1582 | | |
1581 | 1583 | | |
1582 | 1584 | | |
| |||
1594 | 1596 | | |
1595 | 1597 | | |
1596 | 1598 | | |
| 1599 | + | |
1597 | 1600 | | |
1598 | 1601 | | |
1599 | 1602 | | |
| |||
1609 | 1612 | | |
1610 | 1613 | | |
1611 | 1614 | | |
| 1615 | + | |
1612 | 1616 | | |
1613 | 1617 | | |
1614 | 1618 | | |
| |||
0 commit comments