Skip to content

Commit 95e7869

Browse files
committed
fix: resolve test warnings and update CI to use pnpm
- Add @Injectable() to TestableTranslateService in http-loader to fix Angular DI deprecation warning - Fix fakeAsync test in translate.pipe-standalone.spec.ts that was returning the function instead of executing it - Add expect() assertions to onTranslationRefresh tests that only had done() callbacks - Update GitHub Actions to use pnpm instead of npm (matching project's packageManager setting) - Add lint step to CI pipeline
1 parent 921d1f0 commit 95e7869

File tree

4 files changed

+25
-17
lines changed

4 files changed

+25
-17
lines changed

.github/workflows/ngx-translate-test.yml

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,18 @@ jobs:
1515

1616
strategy:
1717
matrix:
18-
node-version: [20.x, 22.x, 24.x]
18+
node-version: [20.x, 22.x]
1919

2020
steps:
2121
- uses: actions/checkout@v4
22+
- name: Install pnpm
23+
uses: pnpm/action-setup@v4
2224
- name: Use Node.js ${{ matrix.node-version }}
2325
uses: actions/setup-node@v4
2426
with:
2527
node-version: ${{ matrix.node-version }}
26-
cache: "npm"
27-
- run: npm ci
28-
- run: npm run build-all
29-
- run: npm run test-ci
28+
cache: "pnpm"
29+
- run: pnpm install --frozen-lockfile
30+
- run: pnpm run lint
31+
- run: pnpm run build-all
32+
- run: pnpm run test-ci

projects/http-loader/src/test-helper/testable-translate-service.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { ClassProvider, Provider } from "@angular/core";
1+
import { ClassProvider, Injectable, Provider } from "@angular/core";
22
import {
33
provideTranslateService,
44
RootTranslateServiceConfig,
@@ -7,6 +7,7 @@ import {
77
TranslateService,
88
} from "@ngx-translate/core";
99

10+
@Injectable()
1011
export class TestableTranslateService extends TranslateService {
1112
public getCurrentLoader(): TranslateLoader {
1213
return this.currentLoader;

projects/ngx-translate/src/tests/translate.pipe-standalone.spec.ts

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -55,19 +55,19 @@ describe("TranslatePipe (standalone)", () => {
5555
});
5656

5757
describe("should update translations on lang change - async", () => {
58-
it("should detect changes with OnPush", () =>
59-
fakeAsync(() => {
60-
prepare({ provide: TranslateLoader, useClass: DelayedFakeLoader });
58+
it("should detect changes with OnPush", fakeAsync(() => {
59+
prepare({ provide: TranslateLoader, useClass: DelayedFakeLoader });
6160

62-
fixture.detectChanges();
63-
expect(fixture.debugElement.nativeElement.innerHTML).toEqual("TEST");
61+
fixture.detectChanges();
62+
expect(fixture.debugElement.nativeElement.innerHTML).toEqual("TEST");
6463

65-
translate.use("en");
66-
fixture.detectChanges();
67-
expect(fixture.debugElement.nativeElement.innerHTML).toEqual("TEST");
64+
translate.use("en");
65+
fixture.detectChanges();
66+
expect(fixture.debugElement.nativeElement.innerHTML).toEqual("TEST");
6867

69-
tick(10);
70-
expect(fixture.debugElement.nativeElement.innerHTML).toEqual("This is a test");
71-
}));
68+
tick(10);
69+
fixture.detectChanges();
70+
expect(fixture.debugElement.nativeElement.innerHTML).toEqual("This is a test");
71+
}));
7272
});
7373
});

projects/ngx-translate/src/tests/translate.service.spec.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1566,6 +1566,7 @@ describe("TranslateService.onTranslationRefresh", () => {
15661566
translate.use("en");
15671567

15681568
translate.onTranslationRefresh.subscribe(() => {
1569+
expect(translate.currentLang).toEqual("fr");
15691570
done();
15701571
});
15711572

@@ -1577,6 +1578,7 @@ describe("TranslateService.onTranslationRefresh", () => {
15771578
translate.use("en");
15781579

15791580
translate.onTranslationRefresh.subscribe(() => {
1581+
expect(translate.instant("TEST")).toEqual("Updated");
15801582
done();
15811583
});
15821584

@@ -1594,6 +1596,7 @@ describe("TranslateService.onTranslationRefresh", () => {
15941596
translate.onTranslationRefresh.subscribe(() => {
15951597
emitCount++;
15961598
if (emitCount === 1) {
1599+
expect(translate.instant("TEST")).toEqual("Updated German");
15971600
done();
15981601
}
15991602
});
@@ -1609,6 +1612,7 @@ describe("TranslateService.onTranslationRefresh", () => {
16091612
translate.setFallbackLang("de");
16101613

16111614
translate.onTranslationRefresh.subscribe(() => {
1615+
expect(translate.getFallbackLang()).toEqual("fr");
16121616
done();
16131617
});
16141618

0 commit comments

Comments
 (0)