Use of @Action Decorator in Provider Class

[bastikempken]

I'm submitting a...

[X] Feature request

Expected behavior

I thought about the feature to attach actions on class level, based on the the concept of a so called provider class. This could be designed as follows:

@State<StateModel>({ name: 'shop', defaults: DEFAULT_SHOP_STATE })
@Injectable()
export class StateClass {
   constructor(private someProviderClass:SomeProviderClass) {
       attachAction(this,someProviderClass)
   }
}

@Injectable()
export class SomeProviderClass {
    @Action(SomeAction)
    someAction(ctx: StateContext<StateModel>, action: SomeAction) { ... }
}

Within the someAction-Method the actions of the SomeProviderClass will be merged to the actions of StateClass.

What is the motivation / use case for changing the behavior?

This could be an alternative, if the user prefers familiar use of the @Action-Decorator. I'm really interested in feedback if it is worth to work on a feature request i would provide.

Thx in advance

[duffleit]

Hi, thanks for the feedback. I like it. We considered an option like this in the beginning of this project. We abandoned it, but I'm not sure about the reasoning anymore to be honest.

Nevertheless, please fill free to try to implement this behavior. I would just not reuse attachAction, but would introduce something new like attachActionProvider.

[bastikempken]

I have created a pull request (still in progress): #4 . Thy in adavanced for feedback.

[bastikempken]

@duffleit Is there a chance to complete the Pull Request soon, im highly interested in the Library and their use in one of my applications :)

[gtteamamxx]

any update? @duffleit