Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@ngxs/schematics should be added to devDependencies #16

Open
xmlking opened this issue Dec 1, 2018 · 10 comments
Open

@ngxs/schematics should be added to devDependencies #16

xmlking opened this issue Dec 1, 2018 · 10 comments

Comments

@xmlking
Copy link

xmlking commented Dec 1, 2018

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => https://github.com/ngxs/store/blob/master/CONTRIBUTING.md
[ ] Other... Please describe:

Current behavior

@ngxs/schematics added to Dependencies

Expected behavior

@ngxs/schematics should be added to devDependencies

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Environment


Libs:
- @angular/core version: X.Y.Z
- @ngxs/store version: X.Y.Z


Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

@markwhitfeld
Copy link
Member

Should it reference itself in its dev dependencies?

@xmlking
Copy link
Author

xmlking commented Dec 1, 2018

@xmlking
Copy link
Author

xmlking commented Dec 1, 2018

@markwhitfeld
Copy link
Member

Yes that makes sense

@kyusupov33
Copy link
Collaborator

@eranshmil @markwhitfeld your solution doesn't solve that problem, because we need to send PR in angular-cli with change on this file: https://github.com/angular/angular-cli/blob/master/packages/angular/cli/tasks/npm-install.ts

As you can see, they set true in save property by default. In our case, we need to improve it and make flag that will understand where package should added.

@kyusupov33
Copy link
Collaborator

@eranshmil
Copy link
Member

@kyusupov33 Thanks for the heads up, I also commented there.

@splincode
Copy link
Member

@kyusupov33 the author of this package, it is strange that he was expelled

@markwhitfeld
Copy link
Member

markwhitfeld commented Feb 13, 2019

@splincode no idea how that happened.
Sorry @kyusupov33, I have added you back as a collaborator.

@kyusupov33
Copy link
Collaborator

@markwhitfeld thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants