Skip to content

Commit a764958

Browse files
committed
Missing stage definition and callback for "SourceKeysStage.CONVERT_SOURCE_ROWS" #246
1 parent 5521b1c commit a764958

File tree

3 files changed

+10
-2
lines changed

3 files changed

+10
-2
lines changed

RELEASE-NOTES.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
* #239 Remove APIs deprecated in 3.0.0
44
* #244 Simplify StringConverter
5+
* #246 Missing stage definition and callback for "SourceKeysStage.CONVERT_SOURCE_ROWS"
56

67
## Release 3.0.0-RC4
78

link-move/src/main/java/com/nhl/link/move/runtime/task/sourcekeys/SourceKeysSegmentProcessor.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,13 @@ public SourceKeysSegmentProcessor(
2727
public void process(Execution exec, SourceKeysSegment segment) {
2828
callbackExecutor.executeCallbacks(SourceKeysStage.EXTRACT_SOURCE_ROWS, exec, segment);
2929

30-
convertSrc(segment);
30+
convertSrc(exec, segment);
3131
collectSourceKeys(exec, segment);
3232
}
3333

34-
private void convertSrc(SourceKeysSegment segment) {
34+
private void convertSrc(Execution exec, SourceKeysSegment segment) {
3535
segment.setSources(rowConverter.convert(segment.getSourceRowsHeader(), segment.getSourceRows()));
36+
callbackExecutor.executeCallbacks(SourceKeysStage.CONVERT_SOURCE_ROWS, exec, segment);
3637
}
3738

3839
private void collectSourceKeys(Execution exec, SourceKeysSegment segment) {

link-move/src/main/java/com/nhl/link/move/runtime/task/sourcekeys/SourceKeysStage.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,11 @@
77
*/
88
public enum SourceKeysStage implements TaskStageType {
99
EXTRACT_SOURCE_ROWS,
10+
11+
/**
12+
* @since 4.0.0
13+
*/
14+
CONVERT_SOURCE_ROWS,
15+
1016
COLLECT_SOURCE_KEYS
1117
}

0 commit comments

Comments
 (0)