Merge branch 'master' into production

# Conflicts:
#	apps/image-editor/index.d.ts

Author: lja1018

apps/image-editor/index.d.ts

@@ -1,4 +1,4 @@
-// Type definitions for TOAST UI Image Editor v3.14.1
+// Type definitions for TOAST UI Image Editor v3.14.2
 // TypeScript Version: 3.2.2
 
 declare namespace tuiImageEditor {

apps/image-editor/package-lock.json

@@ -1,7 +1,7 @@
 {
   "name": "tui-image-editor",
   "author": "NHN. FE Development Lab <[email protected]>",
-  "version": "3.14.1",
+  "version": "3.14.2",
   "license": "MIT",
   "repository": {
     "type": "git",

apps/image-editor/package.json

@@ -129,10 +129,24 @@ class Zoom extends Component {
     this.graphics.on(ADD_TEXT, this._startTextEditingHandler.bind(this));
     this.graphics.on(TEXT_EDITING, this._startTextEditingHandler.bind(this));
     this.graphics.on(OBJECT_MODIFIED, this._stopTextEditingHandler.bind(this));
+  }
+
+  /**
+   * Attach zoom keyboard events
+   */
+  attachKeyboardZoomEvents() {
     fabric.util.addListener(document, KEY_DOWN, this._listeners.keydown);
     fabric.util.addListener(document, KEY_UP, this._listeners.keyup);
   }
 
+  /**
+   * Detach zoom keyboard events
+   */
+  detachKeyboardZoomEvents() {
+    fabric.util.removeListener(document, KEY_DOWN, this._listeners.keydown);
+    fabric.util.removeListener(document, KEY_UP, this._listeners.keyup);
+  }
+
   /**
    * Handler when you started editing text
    * @private
@@ -160,7 +174,6 @@ class Zoom extends Component {
     }
 
     if (e.keyCode === keyCodes.SPACE) {
-      e.preventDefault();
       this.withSpace = true;
       this.startHandMode();
     }
@@ -173,7 +186,6 @@ class Zoom extends Component {
    */
   _endHandModeWithSpaceBar(e) {
     if (e.keyCode === keyCodes.SPACE) {
-      e.preventDefault();
       this.withSpace = false;
       this.endHandMode();
     }

apps/image-editor/src/js/component/zoom.js

@@ -162,6 +162,7 @@ class Graphics {
     this._createDrawingModeInstances();
     this._createComponents();
     this._attachCanvasEvents();
+    this._attachZoomEvents();
   }
 
   /**
@@ -173,6 +174,26 @@ class Graphics {
     this._canvas.clear();
 
     wrapperEl.parentNode.removeChild(wrapperEl);
+
+    this._detachZoomEvents();
+  }
+
+  /**
+   * Attach zoom events
+   */
+  _attachZoomEvents() {
+    const zoom = this.getComponent(components.ZOOM);
+
+    zoom.attachKeyboardZoomEvents();
+  }
+
+  /**
+   * Detach zoom events
+   */
+  _detachZoomEvents() {
+    const zoom = this.getComponent(components.ZOOM);
+
+    zoom.detachKeyboardZoomEvents();
   }
 
   /**

apps/image-editor/src/js/graphics.js

@@ -1,6 +1,6 @@
 {
   "name": "@toast-ui/react-image-editor",
-  "version": "3.14.1",
+  "version": "3.14.2",
   "description": "TOAST UI Image-Editor for React",
   "main": "dist/toastui-react-image-editor.js",
   "files": [
@@ -53,6 +53,6 @@
   },
   "dependencies": {
     "fabric": "^4.2.0",
-    "tui-image-editor": "^3.14.1"
+    "tui-image-editor": "^3.14.2"
   }
 }

apps/react-image-editor/package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@toast-ui/vue-image-editor",
-  "version": "3.14.1",
+  "version": "3.14.2",
   "description": "TOAST UI Image-Editor for Vue",
   "main": "dist/toastui-vue-image-editor.js",
   "files": [
@@ -43,6 +43,6 @@
   },
   "dependencies": {
     "fabric": "^4.2.0",
-    "tui-image-editor": "^3.14.1"
+    "tui-image-editor": "^3.14.2"
   }
 }

apps/react-image-editor/package.json

@@ -2,5 +2,5 @@
   "packages": [
     "apps/*"
   ],
-  "version": "3.14.1"
+  "version": "3.14.2"
 }