Skip to content

Commit f657a75

Browse files
Merge pull request #1912 from nhsuk/revealed-content-border
[v10] Change border colour for details component and conditionally revealed content
2 parents 7705c95 + b21a126 commit f657a75

30 files changed

Lines changed: 15 additions & 4 deletions

File tree

CHANGELOG.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,15 @@ This was added in [pull request #1712: Add support for icon buttons](https://git
5454

5555
### :recycle: **Changes**
5656

57+
#### Change border colour for details component and conditionally revealed content
58+
59+
We've changed the border colour shown to the left of details component and conditionally revealed content.
60+
61+
- Details component border colour changed from grey-4 (`#d8dde0`) to grey-3 (`#aeb7bd`)
62+
- Conditionally revealed border colour changed from grey-1 (`#4c6272`) to grey-3 (`#aeb7bd`)
63+
64+
This change was introduced in [pull request #1788: Change border colour for details component and conditionally revealed content](https://github.com/nhsuk/nhsuk-frontend/pull/1788).
65+
5766
#### Improve screen reader announcements for header search button
5867

5968
We've updated the HTML for the header search button to improve NVDA screen reader announcements.

packages/nhsuk-frontend/src/nhsuk/components/checkboxes/_index.scss

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
@use "sass:math";
22
@use "../../core/settings" as *;
33
@use "../../core/tools" as *;
4+
@use "../../core/helpers" as *;
45
@forward "../error-message";
56
@forward "../fieldset";
67
@forward "../hint";
@@ -193,7 +194,7 @@ $nhsuk-checkboxes-offset: $nhsuk-border-width-form-element;
193194
margin-bottom: $nhsuk-checkboxes-offset;
194195
margin-left: $conditional-margin-left;
195196
padding-left: $conditional-padding-left;
196-
border-left: $nhsuk-border-width solid $nhsuk-input-border-colour;
197+
border-left: $nhsuk-border-width solid nhsuk-colour("grey-3");
197198

198199
.nhsuk-frontend-supported &--hidden {
199200
display: none;

packages/nhsuk-frontend/src/nhsuk/components/details/_index.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ $expander-icon-size: $nhsuk-expander-icon-size;
6161
margin-top: nhsuk-spacing(2);
6262
padding: nhsuk-spacing(3) 0;
6363
padding-left: nhsuk-px-to-rem(20px); // [6]
64-
border-left: nhsuk-spacing(1) solid $nhsuk-border-colour;
64+
border-left: nhsuk-spacing(1) solid nhsuk-colour("grey-3");
6565
}
6666

6767
.nhsuk-details--reverse {
@@ -142,7 +142,7 @@ $expander-icon-size: $nhsuk-expander-icon-size;
142142
padding: nhsuk-spacing(3) 0;
143143
padding-right: 0;
144144
padding-left: 20px; // [6]
145-
border-left: nhsuk-spacing(1) solid $nhsuk-border-colour;
145+
border-left: nhsuk-spacing(1) solid nhsuk-colour("grey-3");
146146

147147
.nhsuk-details--reverse & {
148148
border-left-color: $nhsuk-reverse-border-colour;

packages/nhsuk-frontend/src/nhsuk/components/radios/_index.scss

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
@use "sass:math";
22
@use "../../core/settings" as *;
33
@use "../../core/tools" as *;
4+
@use "../../core/helpers" as *;
45
@forward "../error-message";
56
@forward "../fieldset";
67
@forward "../hint";
@@ -212,7 +213,7 @@ $nhsuk-radios-offset: $nhsuk-border-width-form-element;
212213
margin-bottom: $nhsuk-radios-offset;
213214
margin-left: $conditional-margin-left;
214215
padding-left: $conditional-padding-left;
215-
border-left: $nhsuk-border-width solid $nhsuk-input-border-colour;
216+
border-left: $nhsuk-border-width solid nhsuk-colour("grey-3");
216217

217218
.nhsuk-frontend-supported &--hidden {
218219
display: none;
19 Bytes
Loading
19 Bytes
Loading
23 Bytes
Loading
17 Bytes
Loading
29 Bytes
Loading
14 Bytes
Loading

0 commit comments

Comments
 (0)