Skip to content

Commit 107ef3b

Browse files
authored
Update angular-eslint to 16 (#138)
- Updated dependency on `@angular/core` to `16.2.12` (latest <17) and `@angular-eslint` packages to `16.3.1` (latest <17) - As the `@angular-eslint/recommended--extra` config no longer exists, I inlined the configuration that [used to be in that file](https://github.com/angular-eslint/angular-eslint/blob/v15.2.1/packages/eslint-plugin/src/configs/recommended--extra.json) in lieu of extending it. - The accessibility rules referenced by the config have been renamed to drop the `accessibility-` prefix, so I updated the names in our template config where we had been disabling those rules. - There were two accessibility rules that were not listed in our template config (`interactive-supports-focus` and `role-has-required-aria`), so I added them (in disabled state). - Updated all urls in the repo to reference "main" instead of "master" #### Testing - I ran `npm run print-evaluated-rules:diff` and ensured that the only differences were the renamed accessibility rules. - I ran `npm run print-evaluated-rules` to do an audit, which turned up no warnings or diverged rules. - I ran `npm run print-available-rules` and found that there were the following new, unset rules available in the updated version of @angular-eslint: - `@angular-eslint/prefer-standalone-component` - `@angular-eslint/require-localize-metadata` - `@angular-eslint/sort-lifecycle-methods` - `@angular-eslint/template/prefer-ngsrc` - `@angular-eslint/template/prefer-self-closing-tags`
1 parent 71fedf1 commit 107ef3b

15 files changed

+1311
-876
lines changed

README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -324,11 +324,11 @@ This option can be adapted for npm scripts, for example.
324324

325325
If there are situations where the analysis time for enabling the type checked rules is an excessive burden you may consider creating a separate ESLint configuration that avoids extending the type checked rules and omits the `parserOptions.project` configuration to run in specific scenarios.
326326

327-
See discussion in the [performance section](https://github.com/typescript-eslint/typescript-eslint/blob/master/docs/getting-started/linting/TYPED_LINTING.md#performance) of the Getting Started - Linting with Type Information guide.
327+
See discussion in the [performance section](https://github.com/typescript-eslint/typescript-eslint/blob/main/docs/getting-started/linting/TYPED_LINTING.md#performance) of the Getting Started - Linting with Type Information guide.
328328

329329
### Angular linting performance
330330

331-
Deviations from the `@angular-eslint schematic`, `@ni/eslint-config-angular`, and the [`parserOptions.project`](https://github.com/typescript-eslint/typescript-eslint/tree/master/packages/parser#parseroptionsproject) configurations can result in significant performance degredation. Fully manual configuration [is not recommended](https://github.com/angular-eslint/angular-eslint#going-fully-manual-not-recommended). Read `@angular-eslint`'s [section on performance](https://github.com/angular-eslint/angular-eslint#eslint-configs-and-performance) for information on addressing slow linting processes.
331+
Deviations from the `@angular-eslint schematic`, `@ni/eslint-config-angular`, and the [`parserOptions.project`](https://github.com/typescript-eslint/typescript-eslint/tree/main/packages/parser#parseroptionsproject) configurations can result in significant performance degredation. Fully manual configuration [is not recommended](https://github.com/angular-eslint/angular-eslint#going-fully-manual-not-recommended). Read `@angular-eslint`'s [section on performance](https://github.com/angular-eslint/angular-eslint#eslint-configs-and-performance) for information on addressing slow linting processes.
332332
333333
## License
334334
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "major",
3+
"comment": "Update to Angular 16",
4+
"packageName": "@ni/eslint-config-angular",
5+
"email": "[email protected]",
6+
"dependentChangeType": "patch"
7+
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "none",
3+
"comment": "Url updates in comments",
4+
"packageName": "@ni/eslint-config-javascript",
5+
"email": "[email protected]",
6+
"dependentChangeType": "none"
7+
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "none",
3+
"comment": "Url updates in comments",
4+
"packageName": "@ni/eslint-config-typescript",
5+
"email": "[email protected]",
6+
"dependentChangeType": "none"
7+
}

0 commit comments

Comments
 (0)