Skip to content

Commit 46843c3

Browse files
authored
Add attributes used by SystemLinkShared that shouldn't trigger template/i18n (#143)
As a follow up to #140, our original list of attributes was incomplete. I'm adding the attributes that are needed to build Skyline `Web/Workspaces/SystemLinkShared`. [Here's the SLE PR that is blocked on this](https://dev.azure.com/ni/DevCentral/_git/Skyline/pullrequest/716904)
1 parent c54e179 commit 46843c3

File tree

2 files changed

+13
-0
lines changed

2 files changed

+13
-0
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "patch",
3+
"comment": "Add missing i18n attributes for SystemLinkShared",
4+
"packageName": "@ni/eslint-config-angular",
5+
"email": "[email protected]",
6+
"dependentChangeType": "patch"
7+
}

packages/eslint-config-angular/template/options.js

+6
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ const ignoreAttributeSets = {
1919
'autocomplete',
2020
'column-id',
2121
'field-name',
22+
'filter-mode',
2223
'format',
2324
'icon',
2425
'id-field-name',
@@ -31,6 +32,7 @@ const ignoreAttributeSets = {
3132
'selection-mode',
3233
'severity',
3334
'slot',
35+
'sort-direction',
3436
'theme'
3537
],
3638
systemlink: [
@@ -62,6 +64,10 @@ const ignoreAttributeSets = {
6264

6365
// sl-query-builder
6466
'dropdownWidth',
67+
68+
// native element attributes used by sl components
69+
'accept',
70+
'aria-live',
6571
],
6672
jqx: [
6773
// smart-table

0 commit comments

Comments
 (0)