Merge branch 'main' into disable-playwright-no-await-in-loop

Author: rajsite

.github/CODEOWNERS

@@ -0,0 +1,7 @@
+# Copyright (c) 2023 National Instruments
+
+# Each line is a file pattern followed by one or more owners.
+# More info: https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/creating-a-repository-on-github/about-code-owners
+
+# These owners will be the default owners for everything in the repo.
+* @jattasNI @mure @rajsite @TrevorKarjanis

.github/workflows/build.yml

@@ -7,31 +7,34 @@ on:
 env:
   GITHUB_SERVICE_USER: "rajsite"
   GITHUB_SERVICE_EMAIL: "[email protected]"
+  HAS_GITHUBPAGESDEPLOYTOKEN: ${{secrets.GITHUBPAGESDEPLOYTOKEN != ''}}
+  HAS_NPM_TOKEN: ${{secrets.NPM_TOKEN != ''}}
 
 jobs:
   build:
     runs-on: ubuntu-22.04
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
+      if: env.HAS_GITHUBPAGESDEPLOYTOKEN == 'true'
       with:
-        # Required for beachball changelog detection
-        fetch-depth: 0
         # Must checkout with a token that can push to protected branches for beachball
         # Cannot rely on GITHUB_TOKEN with workflow contents permission
         # See: https://github.com/orgs/community/discussions/40971
         token: ${{ secrets.GITHUBPAGESDEPLOYTOKEN }}
+    - uses: actions/checkout@v4
+      if: env.HAS_GITHUBPAGESDEPLOYTOKEN == 'false'
 
     # Install dependencies
-    - uses: actions/setup-node@v3
+    - uses: actions/setup-node@v4
       with:
-        node-version: '16'
+        node-version: '20'
         registry-url: 'https://registry.npmjs.org'
         cache: 'npm'
     - run: npm ci
 
     # Build
     - run: npm run pack
-    - uses: actions/upload-artifact@v3
+    - uses: actions/upload-artifact@v4
       with:
         name: packages
         path: packages/**/*.tgz
@@ -51,11 +54,11 @@ jobs:
 
     # Publish updates
     - name: Set Git User
-      if: github.repository_owner == 'ni' && startsWith(github.ref, 'refs/heads/main')
+      if: env.HAS_GITHUBPAGESDEPLOYTOKEN == 'true' && startsWith(github.ref, 'refs/heads/main')
       run: |
         git config --global user.name "${{ env.GITHUB_SERVICE_USER }}"
         git config --global user.email "${{ env.GITHUB_SERVICE_EMAIL }}"
-    - if: github.repository_owner == 'ni' && startsWith(github.ref, 'refs/heads/main')
+    - if: env.HAS_GITHUBPAGESDEPLOYTOKEN == 'true' && env.HAS_NPM_TOKEN == 'true' && startsWith(github.ref, 'refs/heads/main')
       env:
         NPM_SECRET_TOKEN: ${{ secrets.NPM_TOKEN }}
       run: npm run publish:ci -- -n $NPM_SECRET_TOKEN

CONTRIBUTING.md

@@ -39,7 +39,15 @@ The goal of the smoke tests is basic validation that the eslint configurations c
 
 ### Creating a pull request
 
-Currently the repository only supports contributions by creating a branch and pull request (we hope to support a fork-pull workflow soon). Not all users can create a branch in this repo; contact @rajsite to be granted the necessary privileges.
+1. Create a fork of the repository.
+2. (optional, but recommended) On the Actions tab of your repository enable actions for the repo. This allows the tests to run in the branches of your fork.
+3. Create and edit a branch in your fork.
+4. Open a pull request to Nimble for the branch.
+   - (optional, but recommended) While creating the pull request enable the "Allow edits and access to secrets by maintainers" option. This will allow maintainers to push small changes to the branch to resolve needed changes quicker.
+5. Create a beachball change file for your project by doing one of the following:
+   1. Follow the [Beachball change file](#beachball-change-file) instructions below to create a change file and push to your branch.
+   2. If you allowed maintainers to edit your branch, they may add a change file for you or request that you add one.
+6. Maintainers will review the PR, may request updates, and eventually merge and release the changes.
 
 ### Beachball change file
 

README.md

@@ -326,11 +326,11 @@ This option can be adapted for npm scripts, for example.
 
 If there are situations where the analysis time for enabling the type checked rules is an excessive burden you may consider creating a separate ESLint configuration that avoids extending the type checked rules and omits the `parserOptions.project` configuration to run in specific scenarios.
 
-See discussion in the [performance section](https://github.com/typescript-eslint/typescript-eslint/blob/master/docs/getting-started/linting/TYPED_LINTING.md#performance) of the Getting Started - Linting with Type Information guide.
+See discussion in the [performance section](https://github.com/typescript-eslint/typescript-eslint/blob/main/docs/getting-started/linting/TYPED_LINTING.md#performance) of the Getting Started - Linting with Type Information guide.
 
 ### Angular linting performance
 
-Deviations from the `@angular-eslint schematic`, `@ni/eslint-config-angular`, and the [`parserOptions.project`](https://github.com/typescript-eslint/typescript-eslint/tree/master/packages/parser#parseroptionsproject) configurations can result in significant performance degredation. Fully manual configuration [is not recommended](https://github.com/angular-eslint/angular-eslint#going-fully-manual-not-recommended). Read `@angular-eslint`'s [section on performance](https://github.com/angular-eslint/angular-eslint#eslint-configs-and-performance) for information on addressing slow linting processes.
+Deviations from the `@angular-eslint schematic`, `@ni/eslint-config-angular`, and the [`parserOptions.project`](https://github.com/typescript-eslint/typescript-eslint/tree/main/packages/parser#parseroptionsproject) configurations can result in significant performance degredation. Fully manual configuration [is not recommended](https://github.com/angular-eslint/angular-eslint#going-fully-manual-not-recommended). Read `@angular-eslint`'s [section on performance](https://github.com/angular-eslint/angular-eslint#eslint-configs-and-performance) for information on addressing slow linting processes.
 
 ## License