Update to Angular 18 (#160)

Addresses #157 

In addition to updating the dependency version, I'm fixing the
following:
- #150
- #153 

## Implementation
Updated dependencies:
 - `@angular/core` to `18.2.13` (latest <19)
 - `@angular-eslint` packages to `18.4.3` (latest <19)
- `@typescript-eslint/eslint-plugin` and `@typescript-eslint/parser` to
`7.18.0` (latest <8)
- After updating the version of `@typescript-eslint/parser`, I began
getting the following test failure:
     ```
Error: Error while loading rule
'@typescript-eslint/prefer-optional-chain': You have used a rule which
requires parserServices to be generated. You must therefore provide a
value for the "parserOptions.project" property for
@typescript-eslint/parser.
Parser:
C:\dev\javascript-styleguide\node_modules\@typescript-eslint\parser\dist\index.js
Occurred while linting
C:\dev\javascript-styleguide\tests\typescript\index.ts
     ```
It turns out that `@typescript-eslint/prefer-optional-chain` now [does
require type
checking](https://typescript-eslint.io/rules/prefer-optional-chain), so
I had to move it to the `requiring-type-checking.js` configuration.
- `@typescript-eslint/eslint-plugin` version 6 [introduced significant
changes](https://github.com/typescript-eslint/typescript-eslint/blob/9e8828b31fda6e0fa45e0397cd6cc4e1662ba356/packages/website/blog/2023-07-09-announcing-typescript-eslint-v6.md#user-facing-breaking-changes).
In `requiring-type-checking.js`, I changed it from extending
`@typescript-eslint/recommended-requiring-type-checking` to
`@typescript-eslint/recommended-type-checked` and
`@typescript-eslint/stylistic-type-checked`. Similarly, in
`eslint-config-typescript/index.js`, I added
`@typescript-eslint/stylistic` to the extended configs. Subsequently,
the output of `npm run print-evaluated-rules:diff` showed over a dozen
changes. I added overrides to minimize the scope of changes in this PR,
and ultimately ended up with the following diff:
- `@typescript-eslint/consistent-generic-constructors` is new ("error")
-- Despite adding an override to turn this rule off, it remains on. This
may be a bug in `@typescript-eslint`. I don't think we want to let this
block us, so clients should either fix reported violations or use
in-source suppressions.
- `@typescript-eslint/lines-between-class-members` was
`["error","always",{"exceptAfterSingleLine":true}]`, now is
`["error","always",{"exceptAfterSingleLine":true,"exceptAfterOverload":true}]`
-- This seems like a harmless difference.
- `no-new-native-nonconstructor` is new ("off") -- Explicitly turning
off this new rule that defaulted to "error".
- `@typescript-eslint/no-duplicate-enum-values` is new ("off") --
Explicitly turning off this new rule that defaulted to "error".
- `@typescript-eslint/no-unsafe-declaration-merging` is new ("off") --
Explicitly turning off this new rule that defaulted to "error".
- `@typescript-eslint/no-duplicate-type-constituents` is new ("off") --
Explicitly turning off this new rule that defaulted to "error".
- `@typescript-eslint/no-redundant-type-constituents` is new ("off") --
Explicitly turning off this new rule that defaulted to "error".
- `@typescript-eslint/no-unsafe-enum-comparison` is new ("off") --
Explicitly turning off this new rule that defaulted to "error".
- `@angular-eslint/runtime-localize` is new ("error") -- We specifically
want this enabled.

### Testing
- Ran `npm run print-evaluated-rules:diff` and handled differences as
described above.
- Ran `npm run print-available-rules` with these changes:
- `@typescript-eslint/no-duplicate-imports` - removed from TS Extensions
- `@typescript-eslint/class-methods-use-this` - added to TS Extensions
   - `@typescript-eslint/max-params` - added to TS Extensions
- `@typescript-eslint/prefer-ts-expect-error` - moved from TS
Recommended to Remaining TS Rules
- `@typescript-eslint/prefer-optional-chain` - moved from TS Recommended
to TS Recommended (Requiring Type Checks)
- `@typescript-eslint/no-implicit-any-catch` - removed from Remaining TS
Rules
- `@typescript-eslint/no-parameter-properties` - removed from Remaining
TS Rules
- `@typescript-eslint/sort-type-union-intersection-members` - removed
from Remaining TS Rules
- `@typescript-eslint/no-empty-object-type` - added to Remaining TS
Rules
- `@typescript-eslint/no-unnecessary-parameter-property-assignment` -
added to Remaining TS Rules
- `@typescript-eslint/no-unsafe-function-type` - added to Remaining TS
Rules
- `@typescript-eslint/no-wrapper-object-types` - added to Remaining TS
Rules
- `@typescript-eslint/no-empty-object-type` - added to Remaining TS
Rules
- `@typescript-eslint/no-empty-object-type` - added to Remaining TS
Rules
- `@typescript-eslint/consistent-return` - added to TS Extensions
(Requiring Type Checks)
- `@typescript-eslint/only-throw-error` - added to TS Extensions
(Requiring Type Checks)
- `@typescript-eslint/prefer-destructuring` - added to TS Extensions
(Requiring Type Checks)
- `@typescript-eslint/prefer-promise-reject-errors` - added to TS
Extensions (Requiring Type Checks)
- `@typescript-eslint/no-array-delete` - added to TS Recommended
(Requiring Type Checks)
- `@typescript-eslint/no-confusing-void-expression` - moved from
Remaining TS Rules (Requiring Type Checks) to TS Recommended (Requiring
Type Checks)
- `@typescript-eslint/no-duplicate-type-constituents` - moved from
Remaining TS Rules (Requiring Type Checks) to TS Recommended (Requiring
Type Checks)
- `@typescript-eslint/no-redundant-type-constituents` - moved from
Remaining TS Rules (Requiring Type Checks) to TS Recommended (Requiring
Type Checks)
- `@typescript-eslint/no-unnecessary-template-expression` - added to TS
Recommended Requiring Type Checks
- `@typescript-eslint/use-unknown-in-catch-callback-variable` - added to
TS Recommended Requiring Type Checks
- `@typescript-eslint/no-unnecessary-type-parameters` - added to
Remaining TS Rules (Requiring Type Checks)
- `@typescript-eslint/no-unsafe-unary-minus` - added to Remaining TS
Rules (Requiring Type Checks)
- `@typescript-eslint/no-useless-template-literals` - added to Remaining
TS Rules (Requiring Type Checks)
- `@typescript-eslint/prefer-find` - added to Remaining TS Rules
(Requiring Type Checks)
- `@angular-eslint/no-host-metadata-property` - moved from Angular
Recommended to Remaining Angular
   - `@angular-eslint/runtime-localize` - added to Remaining Angular

Author: m-akinc

change/@ni-eslint-config-angular-718354fd-7ab1-4395-ac53-e8505b9622bf.json

@@ -0,0 +1,7 @@
+{
+  "type": "major",
+  "comment": "Update to Angular 18",
+  "packageName": "@ni/eslint-config-angular",
+  "email": "[email protected]",
+  "dependentChangeType": "patch"
+}

change/@ni-eslint-config-typescript-c8f0224a-ee12-4ed6-af5b-d65afda76daf.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "Update version of @typescript-eslint/parser and @typescript-eslint/eslint-plugin",
+  "packageName": "@ni/eslint-config-typescript",
+  "email": "[email protected]",
+  "dependentChangeType": "patch"
+}

package-lock.json

@@ -10,6 +10,8 @@ module.exports = {
             https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/src/configs/recommended.json
         */
 
+        '@angular-eslint/no-host-metadata-property': 'error',
+
         /*
             '@angular-eslint/no-input-rename' rule notes:
             Disallow renaming directive inputs generally. Use an inline comment to disable the rule for exceptions where the
@@ -91,6 +93,8 @@ module.exports = {
 
         '@angular-eslint/relative-url-prefix': 'error',
 
+        '@angular-eslint/runtime-localize': 'error',
+
         /*
             Generally not expected in practice to sort NgModule metadata arrays. Projects may enable if desired.
         */

packages/eslint-config-angular/index.js

@@ -32,11 +32,11 @@
     "!/tools"
   ],
   "peerDependencies": {
-    "@angular-eslint/builder": "^17.5.2",
-    "@angular-eslint/eslint-plugin": "^17.5.2",
-    "@angular-eslint/eslint-plugin-template": "^17.5.2",
-    "@angular-eslint/schematics": "^17.5.2",
-    "@angular-eslint/template-parser": "^17.5.2",
+    "@angular-eslint/builder": "^18.4.3",
+    "@angular-eslint/eslint-plugin": "^18.4.3",
+    "@angular-eslint/eslint-plugin-template": "^18.4.3",
+    "@angular-eslint/schematics": "^18.4.3",
+    "@angular-eslint/template-parser": "^18.4.3",
     "@ni/eslint-config-typescript": "^4.4.0"
   }
 }

packages/eslint-config-angular/package.json

@@ -2,6 +2,7 @@ module.exports = {
     extends: [
         '@ni/eslint-config-javascript',
         'plugin:@typescript-eslint/recommended',
+        'plugin:@typescript-eslint/stylistic',
         'plugin:import/typescript',
         './lib/extensions'
     ],
@@ -29,8 +30,6 @@ module.exports = {
 
         '@typescript-eslint/explicit-module-boundary-types': 'error',
 
-        '@typescript-eslint/no-explicit-any': 'error',
-
         /*
             [strict-null-checks]
             With `stickNullChecks` disabled, non-null assertions are discouraged (this rule is configured as 'error')
@@ -40,6 +39,15 @@ module.exports = {
         */
         '@typescript-eslint/no-non-null-assertion': 'error',
 
+        'valid-typeof': 'off',
+
+        /*
+            Overrides to TypeScript stylistic rules:
+            https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/src/configs/stylistic.ts
+        */
+
+        '@typescript-eslint/consistent-generic-constructors': 'off',
+
         /*
             Overrides to Typescript rules outside of the recommended configuration:
         */
@@ -200,8 +208,6 @@ module.exports = {
 
         '@typescript-eslint/prefer-literal-enum-member': 'error',
 
-        '@typescript-eslint/prefer-optional-chain': 'error',
-
         '@typescript-eslint/prefer-ts-expect-error': 'error',
 
         /*
@@ -218,6 +224,6 @@ module.exports = {
         */
         '@typescript-eslint/typedef': 'off',
 
-        '@typescript-eslint/unified-signatures': 'error'
+        '@typescript-eslint/unified-signatures': 'error',
     }
 };

packages/eslint-config-typescript/index.js

@@ -33,7 +33,7 @@
   ],
   "peerDependencies": {
     "@ni/eslint-config-javascript": "^4.3.0",
-    "@typescript-eslint/parser": "^5.62.0",
-    "@typescript-eslint/eslint-plugin": "^5.62.0"
+    "@typescript-eslint/parser": "^7.18.0",
+    "@typescript-eslint/eslint-plugin": "^7.18.0"
   }
 }

packages/eslint-config-typescript/package.json

@@ -1,19 +1,22 @@
 module.exports = {
     extends: [
-        'plugin:@typescript-eslint/recommended-requiring-type-checking',
+        'plugin:@typescript-eslint/recommended-type-checked',
+        'plugin:@typescript-eslint/stylistic-type-checked',
         './lib/extensions-requiring-type-checking'
     ],
     parser: '@typescript-eslint/parser',
     rules: {
         /*
             Overrides to TypeScript recommended rules:
-            https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/src/configs/recommended-requiring-type-checking.ts
+            https://github.com/typescript-eslint/typescript-eslint/tree/v7.18.0/packages/eslint-plugin/src/configs/recommended-type-checked.ts
         */
 
-        /*
-            Allow usage of String.prototype.match for regular expression matching.
-        */
-        '@typescript-eslint/prefer-regexp-exec': 'off',
+        '@typescript-eslint/no-duplicate-enum-values': 'off',
+        '@typescript-eslint/no-duplicate-type-constituents': 'off',
+        '@typescript-eslint/no-loss-of-precision': 'off',
+        '@typescript-eslint/no-redundant-type-constituents': 'off',
+        '@typescript-eslint/no-unsafe-declaration-merging': 'off',
+        '@typescript-eslint/no-unsafe-enum-comparison': 'off',
 
         /*
             This rule can be confusing if you're not familiar with JavaScript's rules for binding `this`,
@@ -48,6 +51,13 @@ module.exports = {
         */
         '@typescript-eslint/unbound-method': ['error', { ignoreStatic: true }],
 
+        /*
+            Overrides to TypeScript type-checked stylistic rules:
+            https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/src/configs/stylistic-type-checked.ts
+        */
+
+        '@typescript-eslint/prefer-regexp-exec': 'off',
+
         /*
             Overrides to Typescript rules outside of the recommended configuration:
         */
@@ -124,6 +134,8 @@ module.exports = {
         */
         '@typescript-eslint/prefer-nullish-coalescing': 'off',
 
+        '@typescript-eslint/prefer-optional-chain': 'error',
+
         '@typescript-eslint/prefer-readonly': 'error',
 
         /*

packages/eslint-config-typescript/requiring-type-checking.js

@@ -1,3 +1,8 @@
+// eslint-plugin-import doesn't know how to resolve entry points in commonjs modules that are
+// declared using "export" rather than the old "main" syntax in package.json.
+// See https://github.com/typescript-eslint/typescript-eslint/issues/7565
+//  and https://github.com/import-js/eslint-plugin-import/issues/2703
+// eslint-disable-next-line import/no-unresolved
 const plugin = require('@typescript-eslint/eslint-plugin');
 
 const isTrue = val => val !== undefined && val !== false;

packages/eslint-config-typescript/tools/print-available-rules.js

@@ -10,7 +10,7 @@
     "@ni/eslint-config-angular": "*"
   },
   "dependencies": {
-    "@angular/core": "^17.3.12"
+    "@angular/core": "^18.2.13"
   },
   "devDependencies": {
     "@types/jasmine": "^5.1.4"

tests/angular/package.json

@@ -10,7 +10,7 @@
     "print-evaluated-rules:no-audit": "node index.js --no-audit"
   },
   "peerDependencies": {
-    "@angular-eslint/eslint-plugin": "^17.5.2",
+    "@angular-eslint/eslint-plugin": "^18.4.3",
     "@ni/angular-test": "*",
     "@ni/eslint-config-angular": "*",
     "@ni/javascript-test": "*",