Improve VIDiff: Detect binary files, Add logic for added/deleted VIs (#49)

Author: shivaCode-2

.github/workflows/mirror-to-gitlab.yml

@@ -7,6 +7,7 @@ on:
 
 jobs:
   mirror-to-gitlab:
+    if: github.repository == 'ni/labview-for-containers'
     runs-on: ubuntu-latest
     steps:
       - name: Checkout repository

.github/workflows/run-vi-analyzer-linux-container.yml

@@ -26,3 +26,10 @@ jobs:
             -v "${{ github.workspace }}:/workspace" \
             nationalinstruments/labview:latest-linux \
             bash -c "cd /workspace/examples/cicd-examples/helper-scripts/run-vi-analyzer && chmod +x run-vi-analyzer.sh && ./run-vi-analyzer.sh"
+
+      - name: Upload VI Analyzer report
+        if: always()
+        uses: actions/upload-artifact@v4
+        with:
+          name: vi-analyzer-report-linux
+          path: ${{ github.workspace }}/examples/cicd-examples/Test-VIs/via-results-temp/

.github/workflows/run-vi-analyzer-windows-container.yml

@@ -26,3 +26,10 @@ jobs:
           -v "${{ github.workspace }}:C:\workspace"
           nationalinstruments/labview:latest-windows
           powershell -File "C:\workspace\examples\cicd-examples\helper-scripts\run-vi-analyzer\run-vi-analyzer.ps1" -WorkspaceRoot "C:\workspace"
+
+      - name: Upload VI Analyzer report
+        if: always()
+        uses: actions/upload-artifact@v4
+        with:
+          name: vi-analyzer-report-windows
+          path: ${{ github.workspace }}\examples\cicd-examples\Test-VIs\via-results-temp\

.github/workflows/vidiff-linux-container.yml

@@ -33,9 +33,9 @@ jobs:
         id: changed-vis
         run: |
           cd pr
-          CHANGED_VIS=$(git diff --name-only --diff-filter=ACMR ${{ github.event.pull_request.base.sha }} ${{ github.sha }} -- '*.vi' || true)
+          CHANGED_VIS=$(git diff --name-only --diff-filter=ACMR ${{ github.event.pull_request.base.sha }} ${{ github.sha }} || true)
           if [ -z "$CHANGED_VIS" ]; then
-            echo "No .vi files changed."
+            echo "No changed files detected."
             echo "has_changes=false" >> "$GITHUB_OUTPUT"
           else
             echo "Changed VI files:"
@@ -78,7 +78,6 @@ jobs:
           mkdir -p metadata
           echo "${{ github.event.pull_request.number }}" > metadata/pr_number
           echo "linux" > metadata/platform
-          echo "${{ steps.changed-vis.outputs.vi_files }}" > metadata/vi_files
 
       - name: Upload metadata
         if: steps.changed-vis.outputs.has_changes == 'true'

.github/workflows/vidiff-windows-container.yml

@@ -34,9 +34,9 @@ jobs:
         shell: bash
         run: |
           cd pr
-          CHANGED_VIS=$(git diff --name-only --diff-filter=ACMR ${{ github.event.pull_request.base.sha }} ${{ github.sha }} -- '*.vi' || true)
+          CHANGED_VIS=$(git diff --name-only --diff-filter=ACMR ${{ github.event.pull_request.base.sha }} ${{ github.sha }} || true)
           if [ -z "$CHANGED_VIS" ]; then
-            echo "No .vi files changed."
+            echo "No changed files detected."
             echo "has_changes=false" >> "$GITHUB_OUTPUT"
           else
             echo "Changed VI files:"
@@ -81,7 +81,6 @@ jobs:
           mkdir -p metadata
           echo "${{ github.event.pull_request.number }}" > metadata/pr_number
           echo "windows" > metadata/platform
-          echo "${{ steps.changed-vis.outputs.vi_files }}" > metadata/vi_files
 
       - name: Upload metadata
         if: steps.changed-vis.outputs.has_changes == 'true'

examples/cicd-examples/Test-VIs/ArthOps.vi

@@ -56,6 +56,15 @@ if (Test-Path -Path $ReportPath) {
 
 Write-Host "Number of failed tests: $failedCount"
 
+# Copy report to workspace for artifact upload
+$resultsDir = Join-Path $WorkspaceRoot "examples\cicd-examples\Test-VIs\via-results-temp"
+if (-not (Test-Path -Path $resultsDir)) {
+    New-Item -ItemType Directory -Path $resultsDir -Force | Out-Null
+}
+if (Test-Path -Path $ReportPath) {
+    Copy-Item -Path $ReportPath -Destination (Join-Path $resultsDir "Results.txt") -Force
+}
+
 if ($failedCount -gt 0) {
     Write-Host "Some tests failed. Exiting with error." -ForegroundColor Red
     Write-Host "########################################################################################"

examples/cicd-examples/helper-scripts/run-vi-analyzer/run-vi-analyzer.ps1

@@ -18,12 +18,13 @@ echo "ReportPath: $REPORT_PATH"
 echo " "
 
 # Run the LabVIEWCLI VIA command.
+CLI_EXIT=0
 LabVIEWCLI -LogToConsole TRUE \
 -OperationName RunVIAnalyzer \
 -ConfigPath $CONFIG_FILE \
 -ReportPath $REPORT_PATH \
 -LabVIEWPath $LABVIEW_PATH \
--Headless
+-Headless || CLI_EXIT=$?
 
 echo "Done running of VI Analyzer Tests"
 echo "Printing Results..."
@@ -47,6 +48,11 @@ fi
 
 echo "Number of failed tests: $FAILED_COUNT"
 
+# Copy report to workspace for artifact upload
+RESULTS_DIR='/workspace/examples/cicd-examples/Test-VIs/via-results-temp'
+mkdir -p "$RESULTS_DIR"
+cp "$REPORT_PATH" "$RESULTS_DIR/Results.txt" 2>/dev/null || true
+
 # 4) Exit based on count
 if (( FAILED_COUNT > 0 )); then
   echo "✖ Some tests failed. Exiting with error."