Change dry_run pattern to match other config modules. Do not bail early.

Signed-off-by: Mark Silva <mark.silva@emerson.com>

Author: texasaggie97

nilrt_snac/_configs/_console_config.py

@@ -14,13 +14,13 @@ def __init__(self):
     def configure(self, args: argparse.Namespace) -> None:
         print("Deconfiguring console access...")
 
-        if args.dry_run:
-            return
+        if not args.dry_run:
+            logger.debug("Disabling console access...")
+            subprocess.run(
+                ["nirtcfg", "--set", "section=systemsettings,token=consoleout.enabled,value=False"],
+                check=True,
+            )
 
-        subprocess.run(
-            ["nirtcfg", "--set", "section=systemsettings,token=consoleout.enabled,value=False"],
-            check=True,
-        )
         opkg.remove("sysconfig-settings-console", force_depends=True)
 
     def verify(self, args: argparse.Namespace) -> bool:

nilrt_snac/_configs/_graphical_config.py

@@ -8,15 +8,17 @@
 
 
 class _GraphicalConfig(_BaseConfig):
-    """The graphical configuration for SNAC is to deconfigure the X11, embedded UI, and other components that are only useful when using the graphical UI.
-    """
+    """The graphical configuration for SNAC is to deconfigure the X11, embedded UI, and other components that are only useful when using the graphical UI."""
 
     def configure(self, args: Namespace) -> None:
         print("Deconfiguring the graphical UI...")
-        if args.dry_run:
-            return
+        if not args.dry_run:
+            logger.debug("Disabling the embedded UI...")
+            run(
+                ["nirtcfg", "--set", "section=systemsettings,token=ui.enabled,value=False"],
+                check=True,
+            )
 
-        run(["nirtcfg", "--set", "section=systemsettings,token=ui.enabled,value=False"], check=True)
         opkg.remove("packagegroup-ni-graphical", autoremove=True)
         opkg.remove("packagegroup-core-x11", autoremove=True)
 

nilrt_snac/_configs/_syslog_ng_config.py

@@ -9,24 +9,28 @@
 class _SyslogConfig(_BaseConfig):
     def __init__(self):
         self._opkg_helper = opkg_helper
-        self.syslog_conf_path = '/etc/syslog-ng/syslog-ng.conf'
+        self.syslog_conf_path = "/etc/syslog-ng/syslog-ng.conf"
 
     def configure(self, args: argparse.Namespace) -> None:
         print("Configuring syslog-ng...")
         dry_run: bool = args.dry_run
-        if dry_run:
-            return
 
         # Check if syslog-ng is already installed
         if not self._opkg_helper.is_installed("syslog-ng"):
             self._opkg_helper.install("syslog-ng")
 
-        # Enable persistent storage
-        _cmd('nirtcfg', '--set', 'section=SystemSettings,token=PersistentLogs.enabled,value="True"')
-
-        # Restart syslog-ng service
-        _cmd('/etc/init.d/syslog', 'restart')
-
+        if not dry_run:
+            # Enable persistent storage
+            logger.debug("Enabling persistent log storage...")
+            _cmd(
+                "nirtcfg",
+                "--set",
+                'section=SystemSettings,token=PersistentLogs.enabled,value="True"',
+            )
+
+            # Restart syslog-ng service
+            logger.debug("Restarting syslog-ng service...")
+            _cmd("/etc/init.d/syslog", "restart")
 
     def verify(self, args: argparse.Namespace) -> bool:
         print("Verifying syslog-ng configuration...")