Skip to content

Commit 0375eca

Browse files
nichu42Copilot
nichu42
and
Copilot
committed
Remove redundant text-scale slider labels from app and widget settings
The 60%/100%/200% (Compact/Default/Double) labels below the text scale sliders are self-explanatory and add visual noise. Drop the label rows and their associated English/German string resources. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent a715022 commit 0375eca

4 files changed

Lines changed: 0 additions & 53 deletions

File tree

‎app/src/main/java/de/nichu42/boxviewer/ui/SettingsScreen.kt‎

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -246,26 +246,6 @@ fun SettingsScreen(
246246
activeTrackColor = MaterialTheme.colorScheme.primary
247247
)
248248
)
249-
Row(
250-
modifier = Modifier.fillMaxWidth(),
251-
horizontalArrangement = Arrangement.SpaceBetween
252-
) {
253-
Text(
254-
stringResource(R.string.settings_text_scale_compact),
255-
style = MaterialTheme.typography.bodySmall,
256-
color = MaterialTheme.colorScheme.onSurfaceVariant
257-
)
258-
Text(
259-
stringResource(R.string.settings_text_scale_default),
260-
style = MaterialTheme.typography.bodySmall,
261-
color = MaterialTheme.colorScheme.onSurfaceVariant
262-
)
263-
Text(
264-
stringResource(R.string.settings_text_scale_double),
265-
style = MaterialTheme.typography.bodySmall,
266-
color = MaterialTheme.colorScheme.onSurfaceVariant
267-
)
268-
}
269249
}
270250

271251
HorizontalDivider(modifier = Modifier.padding(vertical = 4.dp), color = MaterialTheme.colorScheme.outlineVariant.copy(alpha = 0.3f))

‎app/src/main/java/de/nichu42/boxviewer/ui/WidgetConfigScreen.kt‎

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1155,27 +1155,6 @@ fun WidgetConfigScreen(
11551155
activeTrackColor = MaterialTheme.colorScheme.primary
11561156
)
11571157
)
1158-
1159-
Row(
1160-
modifier = Modifier.fillMaxWidth(),
1161-
horizontalArrangement = Arrangement.SpaceBetween
1162-
) {
1163-
Text(
1164-
stringResource(R.string.widget_config_text_scale_compact),
1165-
style = MaterialTheme.typography.bodySmall,
1166-
color = MaterialTheme.colorScheme.onSurfaceVariant
1167-
)
1168-
Text(
1169-
stringResource(R.string.widget_config_text_scale_default),
1170-
style = MaterialTheme.typography.bodySmall,
1171-
color = MaterialTheme.colorScheme.onSurfaceVariant
1172-
)
1173-
Text(
1174-
stringResource(R.string.widget_config_text_scale_double),
1175-
style = MaterialTheme.typography.bodySmall,
1176-
color = MaterialTheme.colorScheme.onSurfaceVariant
1177-
)
1178-
}
11791158
}
11801159
}
11811160

‎app/src/main/res/values-de/strings.xml‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,6 @@
4949
<string name="settings_language_description">Wähle die Sprache für die App-Benutzeroberfläche.</string>
5050
<string name="settings_text_scale_label">App-Textskalierung</string>
5151
<string name="settings_text_scale_description">Passe die relative Textgröße der App-Oberfläche an dein Gerät oder deine Leseentfernung an.</string>
52-
<string name="settings_text_scale_compact">60%% (Kompakt)</string>
53-
<string name="settings_text_scale_default">100%% (Standard)</string>
54-
<string name="settings_text_scale_double">200%% (Doppelt)</string>
5552
<string name="settings_aqi_standard_label">AQI-Standard</string>
5653
<string name="settings_aqi_standard_description">Wähle die Berechnung des Luftqualitätsindex für AQI-Sensoren.</string>
5754
<string name="settings_temperature_unit_label">Temperatureinheit</string>
@@ -377,9 +374,6 @@
377374
<string name="widget_config_section_text_scaling">WIDGET-TEXTSKALIERUNG</string>
378375
<string name="widget_config_text_scaling_description">Passe die relative Textgröße des Widgets an, damit sie perfekt in benutzerdefinierte Layouts passt. Tippe und ziehe unten.</string>
379376
<string name="widget_config_text_scale_label">Widget-Textskalierung</string>
380-
<string name="widget_config_text_scale_compact">60% (Kompakt)</string>
381-
<string name="widget_config_text_scale_default">100% (Standard)</string>
382-
<string name="widget_config_text_scale_double">200% (Doppelt)</string>
383377
<string name="widget_config_section_background_color">HINTERGRUNDFARBE DES WIDGETS</string>
384378
<string name="widget_config_select_preset_palette">Voreingestellte Palette auswählen</string>
385379
<string name="widget_config_advanced_settings">Erweiterte Einstellungen</string>

‎app/src/main/res/values/strings.xml‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,6 @@
6262
<string name="settings_language_description">Choose the language used for the app interface.</string>
6363
<string name="settings_text_scale_label">App Text Scale</string>
6464
<string name="settings_text_scale_description">Adjust the relative text size of the app interface to fit your device or viewing distance.</string>
65-
<string name="settings_text_scale_compact">60%% (Compact)</string>
66-
<string name="settings_text_scale_default">100%% (Default)</string>
67-
<string name="settings_text_scale_double">200%% (Double)</string>
6865
<string name="settings_aqi_standard_label">AQI Standard</string>
6966
<string name="settings_aqi_standard_description">Choose the air quality index calculation used for AQI sensors.</string>
7067
<string name="settings_temperature_unit_label">Temperature Unit</string>
@@ -447,9 +444,6 @@
447444
<string name="widget_config_section_text_scaling">WIDGET TEXT SCALING</string>
448445
<string name="widget_config_text_scaling_description">Adjust the relative text size of the widget to fit custom layouts perfectly. Tap-and-drag below.</string>
449446
<string name="widget_config_text_scale_label">Widget Text Scale</string>
450-
<string name="widget_config_text_scale_compact">60%% (Compact)</string>
451-
<string name="widget_config_text_scale_default">100%% (Default)</string>
452-
<string name="widget_config_text_scale_double">200%% (Double)</string>
453447
<string name="widget_config_section_background_color">WIDGET BACKGROUND COLOR</string>
454448
<string name="widget_config_select_preset_palette">Select a Preset Palette</string>
455449
<string name="widget_config_advanced_settings">Advanced settings</string>

0 commit comments

Comments
 (0)