-
Notifications
You must be signed in to change notification settings - Fork 12
build: wixv4 msi build (fixes #1) #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I've only briefly looked at this, I'll take a deeper look in the next days. I'm wondering if it makes sense to have CI build an msi for every commit on master and for every PR? Personally I don't think so, an msi package only needs to be built for releases which are created manually. |
It's not implemented yet, but it would also be triggered by a release action and then uploaded to the release. The reason for doing it "a lot" is coverage. It's nice to see it break on the PR rather than whenever the release is made. |
This commit adds a WiX v4 MSI build to the project. The build is run from the msi/build.ps1 script. A GitHub workflow is added to run the build and upload the MSI as an artifact.
2020751 to
389c02b
Compare
|
@nickbeth This is rebased to latest and wix is updated to 5.0.2. |
|
I'd probably consider multiple workflows.
|
nickbeth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Sorry for taking so long at this.
This commit adds a WiX v4 MSI build to the project. The build is run from the msi/build.ps1 script. A GitHub workflow is added to run the build and upload the MSI as an artifact.
MSI artifact here: https://github.com/JPHutchins/wsl-usb-manager/actions/runs/11768450149
Closes #1