Skip to content

Conversation

@JPHutchins
Copy link
Contributor

@JPHutchins JPHutchins commented Nov 10, 2024

This commit adds a WiX v4 MSI build to the project. The build is run from the msi/build.ps1 script. A GitHub workflow is added to run the build and upload the MSI as an artifact.

MSI artifact here: https://github.com/JPHutchins/wsl-usb-manager/actions/runs/11768450149

Closes #1

@nickbeth
Copy link
Owner

I've only briefly looked at this, I'll take a deeper look in the next days. I'm wondering if it makes sense to have CI build an msi for every commit on master and for every PR? Personally I don't think so, an msi package only needs to be built for releases which are created manually.

@JPHutchins
Copy link
Contributor Author

I've only briefly looked at this, I'll take a deeper look in the next days. I'm wondering if it makes sense to have CI build an msi for every commit on master and for every PR? Personally I don't think so, an msi package only needs to be built for releases which are created manually.

It's not implemented yet, but it would also be triggered by a release action and then uploaded to the release.

The reason for doing it "a lot" is coverage. It's nice to see it break on the PR rather than whenever the release is made.

This commit adds a WiX v4 MSI build to the project. The build is run
from the msi/build.ps1 script. A GitHub workflow is added to run the
build and upload the MSI as an artifact.
@JPHutchins JPHutchins force-pushed the build/add-msi-wixv4 branch from 2020751 to 389c02b Compare March 23, 2025 01:35
@JPHutchins
Copy link
Contributor Author

@nickbeth This is rebased to latest and wix is updated to 5.0.2.

@DanTheMan827
Copy link

I'd probably consider multiple workflows.

  • A reusable build workflow that builds the app and uploads as an artifact, this could run on every commit as well.
  • An installer workflow that runs on release which calls the build workflow as a job, then has another job that downloads the artifact from that and builds the installer

@JPHutchins JPHutchins requested a review from nickbeth July 14, 2025 02:13
Copy link
Owner

@nickbeth nickbeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Sorry for taking so long at this.

@nickbeth nickbeth merged commit 02f5df8 into nickbeth:master Jul 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add MSI Installer

3 participants