refactor: remove dead code from direct dispatch migration

Remove orphaned artifacts after the MCP direct dispatch refactor:
- Delete skill-inbound.ts (recreated by prettier hook)
- Remove inbound validation, outbound jidPatterns, and outbox system
- Remove router_state table, POLL_INTERVAL, backwards-compat re-exports
- Simplify resolveSkillForJid to use MCP send_message capability

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: nickdirienzo

src/config.ts

@@ -10,7 +10,6 @@ const envConfig = readEnvFile(['ASSISTANT_NAME']);
 
 export const ASSISTANT_NAME =
   process.env.ASSISTANT_NAME || envConfig.ASSISTANT_NAME || 'Andy';
-export const POLL_INTERVAL = 2000;
 export const SCHEDULER_POLL_INTERVAL = 60000;
 
 // Absolute paths needed for container mounts

src/db.ts

@@ -39,10 +39,6 @@ function createSchema(database: Database.Database): void {
     );
     CREATE INDEX IF NOT EXISTS idx_task_run_logs ON task_run_logs(task_id, run_at);
 
-    CREATE TABLE IF NOT EXISTS router_state (
-      key TEXT PRIMARY KEY,
-      value TEXT NOT NULL
-    );
     CREATE TABLE IF NOT EXISTS sessions (
       group_folder TEXT PRIMARY KEY,
       session_id TEXT NOT NULL
@@ -249,21 +245,6 @@ export function logTaskRun(log: TaskRunLog): void {
   );
 }
 
-// --- Router state accessors ---
-
-export function getRouterState(key: string): string | undefined {
-  const row = db
-    .prepare('SELECT value FROM router_state WHERE key = ?')
-    .get(key) as { value: string } | undefined;
-  return row?.value;
-}
-
-export function setRouterState(key: string, value: string): void {
-  db.prepare(
-    'INSERT OR REPLACE INTO router_state (key, value) VALUES (?, ?)',
-  ).run(key, value);
-}
-
 // --- Session accessors ---
 
 export function getSession(groupFolder: string): string | undefined {
@@ -499,9 +480,6 @@ function migrateJsonState(): void {
     }
   };
 
-  // Migrate router_state.json (consume the file even if we no longer use cursor state)
-  migrateFile('router_state.json');
-
   // Migrate sessions.json
   const sessions = migrateFile('sessions.json') as Record<
     string,

src/index.ts

@@ -33,7 +33,6 @@ import { GroupQueue } from './group-queue.js';
 import { resolveGroupFolderPath } from './group-folder.js';
 import { startIpcWatcher } from './ipc.js';
 import { formatMessages, formatOutbound } from './router.js';
-import { writeOutboxEvent } from './outbox.js';
 import { loadSkills, resolveSkillForJid } from './skill-registry.js';
 import { startSchedulerLoop } from './task-scheduler.js';
 import {
@@ -44,9 +43,6 @@ import {
 import { LoadedSkill, NewMessage, RegisteredGroup } from './types.js';
 import { logger } from './logger.js';
 
-// Re-export for backwards compatibility during refactor
-export { escapeXml, formatMessages } from './router.js';
-
 let sessions: Record<string, string> = {};
 let registeredGroups: Record<string, RegisteredGroup> = {};
 
@@ -60,9 +56,7 @@ let skills: LoadedSkill[] = [];
 const pendingMessages = new Map<string, NewMessage[]>();
 
 /**
- * Send a message to a JID via the MCP bridge or skill outbox.
- * MCP skills with send_message are called directly via the bridge.
- * Legacy handler-based skills use the file-based outbox.
+ * Send a message to a JID via the MCP bridge.
  */
 async function sendToJid(jid: string, text: string): Promise<void> {
   const skillName = resolveSkillForJid(skills, jid);
@@ -71,27 +65,16 @@ async function sendToJid(jid: string, text: string): Promise<void> {
     return;
   }
 
-  // Try MCP bridge first (for MCP-based skills like WhatsApp)
   const skill = skills.find((s) => s.manifest.name === skillName);
   if (skill?.manifest.mcp && skill.manifest.scopeTemplate?.send_message) {
     const sent = await callBridgeTool(skillName, 'send_message', {
       recipient: jid,
       message: text,
     });
     if (sent) return;
-    logger.warn(
-      { jid, skillName },
-      'MCP bridge send failed, trying outbox fallback',
-    );
   }
 
-  // Fallback: file-based outbox for handler-based skills
-  writeOutboxEvent(skillName, {
-    type: 'message',
-    jid,
-    text,
-    timestamp: new Date().toISOString(),
-  });
+  logger.warn({ jid, skillName }, 'Failed to send message via MCP bridge');
 }
 
 /**
@@ -463,7 +446,6 @@ async function main(): Promise<void> {
     sendMessage: (jid, text) => sendToJid(jid, text),
     registeredGroups: () => registeredGroups,
     registerGroup,
-    resolveSkillForJid: (jid) => resolveSkillForJid(skills, jid),
     getAvailableGroups,
     writeGroupsSnapshot: (gf, im, ag, rj) =>
       writeGroupsSnapshot(gf, im, ag, rj),

src/ipc.ts

@@ -20,15 +20,13 @@ import {
 } from './db.js';
 import { isValidGroupFolder } from './group-folder.js';
 import { logger } from './logger.js';
-import { writeOutboxEvent } from './outbox.js';
 import { RegisteredGroup } from './types.js';
 
 export interface IpcDeps {
   sendMessage: (jid: string, text: string) => Promise<void>;
   registeredGroups: () => Record<string, RegisteredGroup>;
   registerGroup: (jid: string, group: RegisteredGroup) => void;
   syncGroupMetadata?: (force: boolean) => Promise<void>;
-  resolveSkillForJid?: (jid: string) => string | undefined;
   getAvailableGroups: () => AvailableGroup[];
   writeGroupsSnapshot: (
     groupFolder: string,
@@ -91,22 +89,10 @@ export function startIpcWatcher(deps: IpcDeps): void {
                   try {
                     await deps.sendMessage(data.chatJid, data.text);
                   } catch {
-                    // No channel owns this JID — try skill outbox routing
-                    const skillName = deps.resolveSkillForJid?.(data.chatJid);
-                    if (skillName) {
-                      writeOutboxEvent(skillName, {
-                        type: 'message',
-                        jid: data.chatJid,
-                        text: data.text,
-                        sender: data.sender,
-                        timestamp: new Date().toISOString(),
-                      });
-                    } else {
-                      logger.warn(
-                        { chatJid: data.chatJid, sourceGroup },
-                        'No channel or skill for JID',
-                      );
-                    }
+                    logger.warn(
+                      { chatJid: data.chatJid, sourceGroup },
+                      'Failed to send IPC message',
+                    );
                   }
                   logger.info(
                     { chatJid: data.chatJid, sourceGroup },