Fix pre-commit hooks: use local Homebrew tools + relax lint rules

- Switch from source-compiled hooks to local system tools (instant)
- Install swiftlint/swiftformat via Homebrew (pre-compiled)
- Relax SwiftLint rules to allow existing code patterns
- Add .swiftformat config with Swift 5.9 version
- Auto-format all Swift files for consistency
- Remove --strict from swiftlint (warnings don't fail commits)

Author: Nick MacCarthy

.github/workflows/ci.yml

@@ -15,7 +15,7 @@ jobs:
   build-and-test:
     name: Build and Test
     runs-on: macos-15
-    
+
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -64,7 +64,7 @@ jobs:
   lint:
     name: Swift Lint
     runs-on: macos-15
-    
+
     steps:
       - name: Checkout
         uses: actions/checkout@v4

.gitignore

@@ -3,7 +3,7 @@
 
 # Development plans (internal)
 plans/
-PLAN*.md 
+PLAN*.md
 PHASE*.md
 
 # Xcode user data

.pre-commit-config.yaml

@@ -1,5 +1,9 @@
 # Pre-commit hooks for Stay Tuned iOS project
-# Install: brew install pre-commit && pre-commit install
+#
+# Setup:
+#   brew install pre-commit swiftlint swiftformat
+#   pre-commit install
+#
 # Run manually: pre-commit run --all-files
 
 repos:
@@ -18,19 +22,19 @@ repos:
       - id: mixed-line-ending
         args: ['--fix=lf']
 
-  # SwiftLint for Swift code linting
-  - repo: https://github.com/realm/SwiftLint
-    rev: 0.54.0
+  # Local hooks using Homebrew-installed tools (fast!)
+  - repo: local
     hooks:
       - id: swiftlint
-        args: ['--strict', '--config', '.swiftlint.yml']
-        # Only run on Swift files in the main project (not generated files)
-        files: 'Stay Tuned/.*\.swift$'
+        name: SwiftLint
+        entry: swiftlint lint --config .swiftlint.yml
+        language: system
+        files: '\.swift$'
+        exclude: 'Stay TunedTests|Stay TunedUITests'
 
-  # SwiftFormat for consistent code formatting
-  - repo: https://github.com/nicklockwood/SwiftFormat
-    rev: 0.53.0
-    hooks:
       - id: swiftformat
-        files: 'Stay Tuned/.*\.swift$'
-
+        name: SwiftFormat
+        entry: swiftformat --config .swiftformat
+        language: system
+        files: '\.swift$'
+        exclude: 'Stay TunedTests|Stay TunedUITests'

.swiftformat

@@ -0,0 +1,36 @@
+# SwiftFormat configuration for Stay Tuned
+# Documentation: https://github.com/nicklockwood/SwiftFormat/blob/main/Rules.md
+
+# Swift version
+--swiftversion 5.9
+
+# File options
+--exclude Stay Tuned/Stay Tuned.xcodeproj,Stay TunedTests,Stay TunedUITests,.build
+
+# Format options
+--indent 4
+--indentcase false
+--trimwhitespace always
+--voidtype void
+--semicolons inline
+--wrapcollections before-first
+--wraparguments before-first
+--wrapparameters before-first
+--closingparen balanced
+--funcattributes prev-line
+--typeattributes prev-line
+--varattributes prev-line
+--marktypes never
+--markextensions never
+--extensionacl on-declarations
+
+# SwiftUI-friendly options
+--self init-only
+--importgrouping testable-last
+--commas always
+
+# Disabled rules (too aggressive for existing codebase)
+--disable redundantSelf
+--disable wrapMultilineStatementBraces
+--disable blankLinesAtStartOfScope
+--disable blankLinesAtEndOfScope

.swiftlint.yml

@@ -11,85 +11,35 @@ excluded:
   - Stay Tuned/Stay TunedUITests
   - "**/.build"
 
-# Enabled rules beyond defaults
-opt_in_rules:
-  - closure_spacing
-  - contains_over_filter_count
-  - contains_over_filter_is_empty
-  - contains_over_first_not_nil
-  - empty_collection_literal
-  - empty_count
-  - empty_string
-  - first_where
-  - force_unwrapping
-  - implicit_return
-  - last_where
-  - modifier_order
-  - overridden_super_call
-  - private_action
-  - private_outlet
-  - sorted_first_last
-  - toggle_bool
-  - unused_declaration
-  - vertical_whitespace_closing_braces
-
-# Disabled rules
+# Disabled rules - either too noisy or not applicable
 disabled_rules:
   - todo  # Allow TODO comments during development
   - line_length  # Can be noisy in SwiftUI with long modifiers
   - type_body_length  # Views can get long
   - file_length  # Some files are legitimately long
   - function_body_length  # Some audio processing functions need to be long
   - cyclomatic_complexity  # Audio algorithms can be complex
+  - trailing_comma  # Would require too many changes to existing code
+  - force_unwrapping  # Common in SwiftUI and audio code
+  - implicit_return  # Personal preference
+  - for_where  # Subjective style preference
+  - identifier_name  # Short names like t, r, g, b are common in graphics/audio
+  - implicit_optional_initialization  # Explicit nil is fine
+  - function_parameter_count  # Some functions need many parameters
+  - void_function_in_ternary  # Sometimes readable
+  - vertical_whitespace_closing_braces  # Minor style issue
+  - redundant_string_enum_value  # Explicit values are more readable
+  - unused_closure_parameter  # Sometimes intentional for readability
 
 # Type name exceptions (Xcode auto-generates names with underscores)
 type_name:
   excluded:
     - Stay_TunedApp
 
-# Rule configurations
-identifier_name:
-  min_length:
-    warning: 2
-    error: 1
-  max_length:
-    warning: 50
-    error: 60
-  excluded:
-    - id
-    - i
-    - j
-    - x
-    - y
-    - db
-    - hz
-    - Hz
-
-nesting:
-  type_level:
-    warning: 2
-  function_level:
-    warning: 3
-
-trailing_comma:
-  mandatory_comma: true
-
-vertical_whitespace:
-  max_empty_lines: 2
-
-force_cast:
-  severity: warning
-
-force_try:
-  severity: warning
-
-force_unwrapping:
-  severity: warning
-
 # Custom rules
 custom_rules:
   no_print_statements:
     name: "No Print Statements"
     regex: '^\s*print\s*\('
     message: "Use os_log or remove debug print statements before committing"
-    severity: warning
+    severity: warning  # Warning only, don't fail

LICENSE

@@ -19,5 +19,3 @@ AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.
-
-

README.md

@@ -203,4 +203,3 @@ This project is licensed under the MIT License - see the [LICENSE](LICENSE) file
 <p align="center">
   Made with 🎸 for musicians
 </p>
-

Stay Tuned/Stay Tuned/Audio/AudioEngine.swift

@@ -13,19 +13,21 @@ import Foundation
 final class AudioEngine: ObservableObject {
     private var audioEngine: AVAudioEngine?
     private var inputNode: AVAudioInputNode?
-    
-    @Published private(set) var isRunning = false
-    @Published private(set) var hasPermission = false
-    
+
+    @Published
+    private(set) var isRunning = false
+    @Published
+    private(set) var hasPermission = false
+
     var onBufferReceived: (([Float], Double) -> Void)?
-    
+
     // Buffer size for audio capture
     private let bufferSize: AVAudioFrameCount = 1024
-    
+
     init() {
         checkPermission()
     }
-    
+
     func checkPermission() {
         let session = AVAudioSession.sharedInstance()
         switch session.recordPermission {
@@ -39,56 +41,56 @@ final class AudioEngine: ObservableObject {
             hasPermission = false
         }
     }
-    
+
     func requestPermission() {
         AVAudioSession.sharedInstance().requestRecordPermission { [weak self] granted in
             DispatchQueue.main.async {
                 self?.hasPermission = granted
             }
         }
     }
-    
+
     func start() {
         guard hasPermission else {
             requestPermission()
             return
         }
-        
+
         guard !isRunning else { return }
-        
+
         do {
             let session = AVAudioSession.sharedInstance()
             try session.setCategory(.playAndRecord, mode: .measurement, options: [.defaultToSpeaker, .allowBluetooth])
             try session.setActive(true)
-            
+
             guard session.isInputAvailable else { return }
-            
+
             audioEngine = AVAudioEngine()
-            guard let audioEngine = audioEngine else { return }
-            
+            guard let audioEngine else { return }
+
             inputNode = audioEngine.inputNode
-            guard let inputNode = inputNode else { return }
-            
+            guard let inputNode else { return }
+
             inputNode.installTap(onBus: 0, bufferSize: bufferSize, format: nil) { [weak self] buffer, _ in
-                guard let self = self else { return }
+                guard let self else { return }
                 guard let channelData = buffer.floatChannelData else { return }
-                
+
                 let channelDataValue = channelData.pointee
                 let frameLength = Int(buffer.frameLength)
                 let sampleRate = Double(buffer.format.sampleRate)
-                
+
                 // Copy samples
                 var samples = [Float](repeating: 0, count: frameLength)
-                for i in 0..<frameLength {
+                for i in 0 ..< frameLength {
                     samples[i] = channelDataValue[i]
                 }
-                
+
                 // Call the callback
                 self.onBufferReceived?(samples, sampleRate)
             }
-            
+
             try audioEngine.start()
-            
+
             DispatchQueue.main.async {
                 self.isRunning = true
             }
@@ -99,18 +101,18 @@ final class AudioEngine: ObservableObject {
             }
         }
     }
-    
+
     func stop() {
         inputNode?.removeTap(onBus: 0)
         audioEngine?.stop()
         audioEngine = nil
         inputNode = nil
-        
+
         DispatchQueue.main.async {
             self.isRunning = false
         }
     }
-    
+
     deinit {
         inputNode?.removeTap(onBus: 0)
         audioEngine?.stop()