Skip to content

Commit 198ae53

Browse files
nickolas122claude
andcommitted
Ship the debug protobuf DLLs the Windows build actually imports
The published Windows zip cannot start. Its exe imports libprotobufd.dll and the debug abseil_dll.dll - objdump on the shipped binary says so - and the folder contains libprotobuf.dll and the release abseil instead. The loader fails before main(), so there is no window and no log: STATUS_DLL_NOT_FOUND and nothing else. The build is `nmake debug` and defaults.pri picks the debug half of vcpkg to match the CRT, which puts those DLLs in vcpkg's debug\bin. Deploy copied only bin. The step immediately above it, which runs the tests, has known about debug\bin since it was written - its comment even names the 0xC0000135 this produces - and the knowledge never made it eight lines down. Both halves are copied now, debug last so it wins abseil_dll.dll, the one name they share. The release copies are dead weight rather than a hazard: nothing imports them. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
1 parent a1fcd5c commit 198ae53

1 file changed

Lines changed: 7 additions & 0 deletions

File tree

.github/workflows/main.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -670,7 +670,14 @@ jobs:
670670
if ($LASTEXITCODE -ne 0) { throw "windeployqt failed: $LASTEXITCODE" }
671671
cp ../../../icons/iOS/iTunesArtwork@2x.png .
672672
cp ../../AppxManifest.xml .
673+
# Both halves, debug last so it wins the names they share. This is
674+
# `nmake debug`, so the exe imports libprotobufd.dll and the debug
675+
# abseil_dll.dll - and those live in debug\bin, which this step was not
676+
# copying. The result was a published zip whose exe cannot start at all:
677+
# STATUS_DLL_NOT_FOUND before main(), no window and no log to say why.
678+
# The test step above has known about debug\bin since it was written.
673679
Copy-Item -Path "$vcpkg\bin\*.dll" -Destination . -Verbose
680+
Copy-Item -Path "$vcpkg\debug\bin\*.dll" -Destination . -Force -Verbose
674681
mkdir adb
675682
cp ../../adb/* adb/
676683

0 commit comments

Comments
 (0)