grove/tests/test_workspace.py at 73758ff42a398f9ef01bb56aebe8052c134d34b4 · nicksenap/grove · GitHub

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
"""Tests for grove.workspace — create, delete, status with mocked git."""

from __future__ import annotations

from unittest.mock import patch

import pytest

from grove import state, workspace
from grove.git import GitError
from grove.models import Config


@pytest.fixture()
def mock_git():
    """Patch all git operations used by workspace module."""
    with (
        patch("grove.workspace.git.worktree_has_branch", return_value=False),
        patch("grove.workspace.git.branch_exists", return_value=True),
        patch("grove.workspace.git.create_branch"),
        patch("grove.workspace.git.worktree_add"),
        patch("grove.workspace.git.worktree_remove"),
        patch("grove.workspace.git.current_branch", return_value="feat/test"),
        patch("grove.workspace.git.repo_status", return_value=""),
    ):
        yield


class TestCreateWorkspace:
    def test_success(self, tmp_grove, mock_git):
        cfg = Config(
            repos_dir=tmp_grove["repos_dir"],
            workspace_dir=tmp_grove["workspace_dir"],
        )
        repo_path = tmp_grove["repos_dir"] / "svc-api"
        repo_path.mkdir()
        repos = {"svc-api": repo_path}

        ws = workspace.create_workspace("test", repos, "feat/test", cfg)
        assert ws is not None
        assert ws.name == "test"
        assert ws.branch == "feat/test"
        assert len(ws.repos) == 1
        assert ws.repos[0].repo_name == "svc-api"

        # Verify state saved
        saved = state.get_workspace("test")
        assert saved is not None

    def test_duplicate_name_fails(self, tmp_grove, mock_git, sample_workspace):
        state.add_workspace(sample_workspace)
        cfg = Config(
            repos_dir=tmp_grove["repos_dir"],
            workspace_dir=tmp_grove["workspace_dir"],
        )
        ws = workspace.create_workspace("test-ws", {}, "feat/x", cfg)
        assert ws is None

    def test_duplicate_branch_fails(self, tmp_grove):
        with patch("grove.workspace.git.worktree_has_branch", return_value=True):
            cfg = Config(
                repos_dir=tmp_grove["repos_dir"],
                workspace_dir=tmp_grove["workspace_dir"],
            )
            repo_path = tmp_grove["repos_dir"] / "svc-api"
            repo_path.mkdir()
            ws = workspace.create_workspace("test", {"svc-api": repo_path}, "feat/taken", cfg)
            assert ws is None

    def test_rollback_on_worktree_failure(self, tmp_grove):
        cfg = Config(
            repos_dir=tmp_grove["repos_dir"],
            workspace_dir=tmp_grove["workspace_dir"],
        )
        repo1 = tmp_grove["repos_dir"] / "repo1"
        repo2 = tmp_grove["repos_dir"] / "repo2"
        repo1.mkdir()
        repo2.mkdir()

        call_count = 0

        def failing_worktree_add(repo, wt_path, branch):
            nonlocal call_count
            call_count += 1
            if call_count > 1:
                raise GitError("disk full")

        with (
            patch("grove.workspace.git.worktree_has_branch", return_value=False),
            patch("grove.workspace.git.branch_exists", return_value=True),
            patch("grove.workspace.git.worktree_add", side_effect=failing_worktree_add),
            patch("grove.workspace.git.worktree_remove") as mock_remove,
        ):
            ws = workspace.create_workspace("test", {"repo1": repo1, "repo2": repo2}, "feat/x", cfg)
            assert ws is None
            # First worktree should be rolled back
            assert mock_remove.called

    def test_auto_creates_branch(self, tmp_grove):
        cfg = Config(
            repos_dir=tmp_grove["repos_dir"],
            workspace_dir=tmp_grove["workspace_dir"],
        )
        repo_path = tmp_grove["repos_dir"] / "svc-api"
        repo_path.mkdir()

        with (
            patch("grove.workspace.git.fetch"),
            patch("grove.workspace.git.worktree_has_branch", return_value=False),
            patch("grove.workspace.git.branch_exists", return_value=False),
            patch("grove.workspace.git.default_branch", return_value="origin/main"),
            patch("grove.workspace.git.create_branch") as mock_create,
            patch("grove.workspace.git.worktree_add"),
        ):
            ws = workspace.create_workspace("test", {"svc-api": repo_path}, "feat/new", cfg)
            assert ws is not None
            mock_create.assert_called_once_with(repo_path, "feat/new", start_point="origin/main")


class TestSetupHook:
    def test_runs_setup_command(self, tmp_grove):
        cfg = Config(
            repos_dir=tmp_grove["repos_dir"],
            workspace_dir=tmp_grove["workspace_dir"],
        )
        repo_path = tmp_grove["repos_dir"] / "svc-api"
        repo_path.mkdir()

        with (
            patch("grove.workspace.git.fetch"),
            patch("grove.workspace.git.worktree_has_branch", return_value=False),
            patch("grove.workspace.git.branch_exists", return_value=True),
            patch("grove.workspace.git.worktree_add"),
            patch("grove.workspace.subprocess.run") as mock_sub,
            patch(
                "grove.workspace.git.read_grove_config",
                return_value={"setup": "pnpm install"},
            ) as mock_cfg,
        ):
            ws = workspace.create_workspace("test", {"svc-api": repo_path}, "feat/x", cfg)
            assert ws is not None
            # Config should be read from the source repo, not the worktree
            mock_cfg.assert_called_once_with(repo_path)
            mock_sub.assert_called_once_with(
                "pnpm install",
                cwd=ws.path / "svc-api",
                shell=True,
                check=True,
            )

    def test_runs_multiple_setup_commands(self, tmp_grove):
        cfg = Config(
            repos_dir=tmp_grove["repos_dir"],
            workspace_dir=tmp_grove["workspace_dir"],
        )
        repo_path = tmp_grove["repos_dir"] / "web"
        repo_path.mkdir()

        with (
            patch("grove.workspace.git.fetch"),
            patch("grove.workspace.git.worktree_has_branch", return_value=False),
            patch("grove.workspace.git.branch_exists", return_value=True),
            patch("grove.workspace.git.worktree_add"),
            patch("grove.workspace.subprocess.run") as mock_sub,
            patch(
                "grove.workspace.git.read_grove_config",
                return_value={"setup": ["pnpm install", "pnpm build"]},
            ),
        ):
            ws = workspace.create_workspace("test", {"web": repo_path}, "feat/x", cfg)
            assert ws is not None
            assert mock_sub.call_count == 2

    def test_no_setup_no_crash(self, tmp_grove):
        cfg = Config(
            repos_dir=tmp_grove["repos_dir"],
            workspace_dir=tmp_grove["workspace_dir"],
        )
        repo_path = tmp_grove["repos_dir"] / "svc"
        repo_path.mkdir()

        with (
            patch("grove.workspace.git.fetch"),
            patch("grove.workspace.git.worktree_has_branch", return_value=False),
            patch("grove.workspace.git.branch_exists", return_value=True),
            patch("grove.workspace.git.worktree_add"),
            patch("grove.workspace.git.read_grove_config", return_value={}),
        ):
            ws = workspace.create_workspace("test", {"svc": repo_path}, "feat/x", cfg)
            assert ws is not None


class TestDeleteWorkspace:
    def test_success(self, tmp_grove, sample_workspace):
        state.add_workspace(sample_workspace)
        with patch("grove.workspace.git.worktree_remove"):
            result = workspace.delete_workspace("test-ws")
        assert result is True
        assert state.get_workspace("test-ws") is None

    def test_not_found(self, tmp_grove):
        result = workspace.delete_workspace("nope")
        assert result is False


class TestWorkspaceStatus:
    def test_clean_repos(self, tmp_grove, sample_workspace):
        with (
            patch("grove.workspace.git.current_branch", return_value="feat/test"),
            patch("grove.workspace.git.repo_status", return_value=""),
        ):
            results = workspace.workspace_status(sample_workspace)
            assert len(results) == 1
            assert results[0]["status"] == "clean"
            assert results[0]["branch"] == "feat/test"

    def test_modified_repo(self, tmp_grove, sample_workspace):
        with (
            patch("grove.workspace.git.current_branch", return_value="feat/test"),
            patch("grove.workspace.git.repo_status", return_value=" M file.py\n?? new.txt"),
        ):
            results = workspace.workspace_status(sample_workspace)
            assert results[0]["status"] == " M file.py\n?? new.txt"

    def test_git_error(self, tmp_grove, sample_workspace):
        with (
            patch("grove.workspace.git.current_branch", side_effect=GitError("broken")),
        ):
            results = workspace.workspace_status(sample_workspace)
            assert results[0]["branch"] == "?"
            assert "error" in results[0]["status"]