fix(epp): use real flag names in config-file/config-text error (llm-d#1942)

* fix(epp): use real flag names in config-file/config-text error

The Validate() error for setting --config-file and --config-text together
named the flags "configText" and "configFile", but they are registered as
"config-file" and "config-text". Users could not map the message back to a
flag. Use the registered kebab-case names, matching every other error in
Validate(), and add a regression test asserting both names appear.

Signed-off-by: Anas Khan <83116240+anxkhn@users.noreply.github.com>

* fix(epp): use cannot in config flag error

Signed-off-by: Anas Khan <83116240+anxkhn@users.noreply.github.com>

---------

Signed-off-by: Anas Khan <83116240+anxkhn@users.noreply.github.com>

Author: anxkhn

pkg/epp/server/options.go

@@ -299,7 +299,7 @@ func (opts *Options) Validate() error {
 	}
 
 	if opts.ConfigText != "" && opts.ConfigFile != "" {
-		return fmt.Errorf("both the %q and %q flags can not be set at the same time", "configText", "configFile")
+		return fmt.Errorf("both the %q and %q flags cannot be set at the same time", "config-file", "config-text")
 	}
 	if opts.ModelServerMetricsScheme != "http" && opts.ModelServerMetricsScheme != "https" {
 		return fmt.Errorf("unexpected %q value for %q flag, it can only be set to 'http' or 'https'",

pkg/epp/server/options_test.go

@@ -17,6 +17,7 @@ limitations under the License.
 package server
 
 import (
+	"strings"
 	"testing"
 	"time"
 
@@ -267,3 +268,20 @@ func TestDrainTimeoutFlag(t *testing.T) {
 		t.Errorf("DrainTimeout = %v, want 30s", opts.DrainTimeout)
 	}
 }
+
+func TestValidateConfigFlagsMutuallyExclusive(t *testing.T) {
+	opts := NewOptions()
+	opts.PoolName = "config-flags-pool" // bypass the pool/selector validation
+	opts.ConfigFile = "fake-config.yaml"
+	opts.ConfigText = "fake: config"
+
+	err := opts.Validate()
+	if err == nil {
+		t.Fatalf("Expected Validate() to fail when both config flags are set, but it succeeded")
+	}
+	for _, want := range []string{"config-file", "config-text"} {
+		if !strings.Contains(err.Error(), want) {
+			t.Errorf("Validate() error must reference the %q flag, got: %v", want, err)
+		}
+	}
+}