Skip to content

Commit 2f63982

Browse files
committed
[socket] fix multi-tab and cors
1 parent b35b002 commit 2f63982

File tree

7 files changed

+1601
-675
lines changed

7 files changed

+1601
-675
lines changed

socket/channel.go

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,6 @@ func (c *Channel) Join(topic string, handler JoinHandler) {
8585
if err := c.joinHandlers.Insert(topic, handler); err != nil {
8686
panic(fmt.Sprintf("[chain.socket] invalid join handler for topic. Topic: %s, Error: %s", topic, err.Error()))
8787
}
88-
return
8988
}
9089

9190
// HandleIn Handle incoming `event`s.
@@ -193,7 +192,7 @@ func (c *Channel) Dispatch(topic string, msg any, from string) {
193192
var sockets []*Socket
194193
if len(c.sockets) > 0 {
195194
if ss, exist := c.sockets[topic]; exist {
196-
for socket, _ := range ss {
195+
for socket := range ss {
197196
sockets = append(sockets, socket)
198197
}
199198
}
@@ -229,11 +228,6 @@ func (c *Channel) Dispatch(topic string, msg any, from string) {
229228
}
230229
}
231230

232-
// validate @todo checks if all handlers are configured correctly
233-
func (c *Channel) validate() (err error) {
234-
return nil
235-
}
236-
237231
func (c *Channel) handleJoin(topic string, payload any, socket *Socket) (reply any, err error) {
238232
defer func() {
239233
if rcv := recover(); rcv != nil {
@@ -290,7 +284,6 @@ func (c *Channel) handleLeave(socket *Socket, reason LeaveReason) {
290284
}
291285
}
292286
}
293-
return
294287
}
295288

296289
func (c *Channel) handleIn(event string, payload any, socket *Socket) (reply any, err error) {

socket/client/README.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
# Chain client (Socket, Channel)
2+
3+
## Build
4+
5+
```
6+
npm install -g typescript
7+
tsc chain.ts
8+
```

0 commit comments

Comments
 (0)