Safety issue: can't stop an ongoing bolus after closing AAPS

[vanelsberg]

AndroidAPS 3.3.3-dev: Lates dev builds
Flavor: fullrelease

Problem:
When executing a manual bolus the resulting pop-up screen will show bolus progress and a "STOP" button to cancel the onging bolus. Closing the app (using Android UI "Close All" or swiping) does not stop the bolus by design. However, when I reopen the AAPS app it only shows the (still) ongoing bolus at the bottom of the overview screen without a STOP button to cancel.

Considering safety, one could argue that this is not acceptable

Additional info:
To STOP the bolus then user has no other option then to forcefully close AAPS through settings, restart the phone, disconnect the pump or
(when running the AAPS Wear app) using the option to cancel the bolus from the watch.

Screenprints:

Ongoing bolus with STOP button enables canceling the ongoing bolus.

After closing and reopening AAPS: ther is no way to STOP the ongoing bolus

[andyrozman]

I would say that is by design... Closing AAPS shouldn't cancel the bolus, unless user presses the button...

Now... Good question... Why did you do the "Close All" while bolus was executing... You need to wait until all commands are executed and then you can close your AAPS...

That small thing there is just showing that command is executed. You can cancel command only while you are in original AAPS instance and when command was issued... AND this is especially true if you are using pump which has no other way of cancelling command (pod pumps without screen and buttons).

[vanelsberg]

Yes. By design and this is correct.

Why did you do the "Close All" while bolus was executing...

I did to show that when you do, there is no way to stop the ongoing bolus.

• Think about a user entering a large bolus, then realizing this was wrong and panicking - swipes/closes AAPS to stop it...

When close/open AAPS I still can STOP the bolus from the watch. Can't see any reason why this would not be possible from AAPS?

[andyrozman]

• Think about a user entering a large bolus, then realizing this was wrong and panicking - swipes/closes AAPS to stop it...

Yes simple solution, press that little button with "Stop" text on it. I don't see anything wrong with how it works... But that is for Milos to decide...

[robertrub]

@vanelsberg I think, if you had used the "back" button of Android, you'd see the progression window with the stop button.

EDIT : Discard my message. Just tested, back doesn't bring back the progression bar.

[vanelsberg]

Imho:
Any situation where user loses control over what the pump is doing is "not be design" and "potentially dangerous" 🤔

[vanelsberg]

@MilosKozak Merged PR4229 with current dev commits.

@Angus-repo No issues (used your AAPS pr-CI btw 😄)
NICE! Works as expected ❤️

[robertrub]

Building dev now. Will test and report.

[robertrub]

@Angus-repo Works as expected but there is a small bug.

I start a 0.5U bolus, Android 3 vertical bar, Close all. Open AAPS again.

I see the progression bar (that part is working ok) but the total amount on top of the page is wrong. It probably shows the amount already injected when I closed all

The xU injected / total yU to be injected line is correct.

[Angus-repo]

@Angus-repo Works as expected but there is a small bug.

I start a 0.5U bolus, Android 3 vertical bar, Close all. Open AAPS again.

I see the progression bar (that part is working ok) but the total amount on top of the page is wrong. It probably shows the amount already injected when I closed all

The xU injected / total yU to be injected line is correct.

@robertrub Which type of pump are you using?

[robertrub]

@Angus-repo The bug happens even if I quit AAPS and come back to it (without closing it).

Screenshot during lunch bolus. I went to another app then back to AAPS.

It used to show the total amount on top and the progression /total amount over the progression bar.

I'm using the Medtrum Nano pump.

[MilosKozak]

I'll try to fix it

[robertrub]

@MilosKozak If it helps : bolus running, if I turn off the screen, wait a bit and turn it ON again, I get this screen for around 1 second (a lot of missing information). Then, it fills up.

[Angus-repo]

Got it, I’ll also try to resolve it.

[MilosKozak]

@Angus-repo I will do larger refactoring and cleanup. This code is 10 years old