perf: optimize activity and food storage with bulkWrite

Replace sequential replaceOne calls with bulkWrite for batch upserts.
This improves performance when inserting multiple documents at once.

- activity.js: Use bulkWrite with replaceOne ops instead of forEach loop
- food.js: Same optimization for consistency

Both maintain exact same upsert behavior (query by _id+created_at or doc).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: bewest

lib/server/activity.js

@@ -7,22 +7,39 @@ function storage (env, ctx) {
    var ObjectID = require('mongodb-legacy').ObjectId;
 
   function create (docs, fn) {
-    var firstErr = null
-      , numDocs = docs.length
-      , totalCreated = 0;
+    if (docs.length === 0) {
+      return fn(null, []);
+    }
 
-    docs.forEach(function(doc) {
+    // Build bulkWrite operations for batch upsert
+    var bulkOps = docs.map(function(doc) {
       if (!Object.prototype.hasOwnProperty.call(doc, 'created_at')) {
-        doc.created_at = (new Date( )).toISOString( );
+        doc.created_at = (new Date()).toISOString();
       }
       var query = (doc.created_at && doc._id) ? { _id: doc._id, created_at: doc.created_at } : doc;
-      api().replaceOne(query, doc, { upsert: true }, function(err, updateResults) {
-        firstErr = firstErr || err;
-
-        if (++totalCreated === numDocs) {
-          fn(firstErr, docs);
+      return {
+        replaceOne: {
+          filter: query,
+          replacement: doc,
+          upsert: true
         }
-      });
+      };
+    });
+
+    api().bulkWrite(bulkOps, { ordered: true }, function(err, bulkResult) {
+      if (err) {
+        console.error('Problem upserting activity batch', err);
+        return fn(err, []);
+      }
+
+      // Assign _ids from upserted results
+      if (bulkResult && bulkResult.upsertedIds) {
+        Object.keys(bulkResult.upsertedIds).forEach(function(index) {
+          docs[index]._id = bulkResult.upsertedIds[index];
+        });
+      }
+
+      fn(null, docs);
     });
   }
 

lib/server/food.js

@@ -9,20 +9,37 @@ function storage (env, ctx) {
       docs = [docs];
     }
 
-    var firstErr = null
-      , numDocs = docs.length
-      , totalCreated = 0;
+    if (docs.length === 0) {
+      return fn(null, []);
+    }
 
-    docs.forEach(function(doc) {
-      doc.created_at = (new Date( )).toISOString( );
+    // Build bulkWrite operations for batch upsert
+    var bulkOps = docs.map(function(doc) {
+      doc.created_at = (new Date()).toISOString();
       var query = (doc.created_at && doc._id) ? { _id: doc._id, created_at: doc.created_at } : doc;
-      api().replaceOne(query, doc, { upsert: true }, function(err, updateResults) {
-        firstErr = firstErr || err;
-
-        if (++totalCreated === numDocs) {
-          fn(firstErr, docs);
+      return {
+        replaceOne: {
+          filter: query,
+          replacement: doc,
+          upsert: true
         }
-      });
+      };
+    });
+
+    api().bulkWrite(bulkOps, { ordered: true }, function(err, bulkResult) {
+      if (err) {
+        console.error('Problem upserting food batch', err);
+        return fn(err, []);
+      }
+
+      // Assign _ids from upserted results
+      if (bulkResult && bulkResult.upsertedIds) {
+        Object.keys(bulkResult.upsertedIds).forEach(function(index) {
+          docs[index]._id = bulkResult.upsertedIds[index];
+        });
+      }
+
+      fn(null, docs);
     });
   }