Skip to content

Commit 7ae17b1

Browse files
authored
Merge pull request #8433 from nightscout/test/node22-pr
Test/node22 pr
2 parents 535b50e + 0fb628e commit 7ae17b1

File tree

5 files changed

+4229
-1182
lines changed

5 files changed

+4229
-1182
lines changed

.github/workflows/main.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
runs-on: ubuntu-latest
1717
strategy:
1818
matrix:
19-
node-version: [14.x, 16.x, 20, lts/*]
19+
node-version: [16, 20, 22]
2020
mongodb-version: [4.4, 5.0, 6.0]
2121

2222
steps:

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM node:16.16.0-alpine
1+
FROM node:22-alpine
22

33
LABEL maintainer="Nightscout Contributors"
44

lib/server/bootevent.js

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,15 +38,19 @@ function boot (env, language) {
3838

3939
const isLTS = process.release.lts ? true : false;
4040

41-
if (isLTS || (semver.satisfies(nodeVersion, '^20.0.0') || semver.satisfies(nodeVersion, '^18.0.0') || semver.satisfies(nodeVersion, '^16.0.0') || semver.satisfies(nodeVersion, '^14.0.0'))) {
42-
//Latest Node 14 LTS and Node 16 LTS are recommended and supported.
43-
//Require at least Node 14 without known security issues
44-
console.debug('Node LTS version ' + nodeVersion + ' is supported');
41+
// Node 16+ is supported (overlap with previous release)
42+
// Recommended: Node 20 LTS (until April 2026) or Node 22 LTS (until April 2027)
43+
if (semver.satisfies(nodeVersion, '>=16.x')) {
44+
if (isLTS) {
45+
console.debug('Node LTS version ' + nodeVersion + ' is supported');
46+
} else {
47+
console.debug('Node version ' + nodeVersion + ' is supported (current release)');
48+
}
4549
next();
4650
return;
4751
}
4852

49-
console.log( 'ERROR: Node version ' + nodeVersion + ' is not supported. Please use a secure LTS version or upgrade your Node');
53+
console.log( 'ERROR: Node version ' + nodeVersion + ' is not supported. Please use Node 16 or later.');
5054
process.exit(1);
5155

5256
}

0 commit comments

Comments
 (0)