build!: switch to esm (#240)

BREAKING CHANGE: This drops support for Node 18, and switches to a pure ESM package. This means that you either have to use `"type": "module"` in your `package.json`, or upgrade to a Node version that supports [require(esm)](https://nodejs.org/api/modules.html#loading-ecmascript-modules-using-require), i.e. >= [v20.19.0](https://nodejs.org/en/blog/release/v20.19.0#requireesm-is-now-enabled-by-default), >= [v22.12.0](https://nodejs.org/en/blog/release/v22.12.0#requireesm-is-now-enabled-by-default), or v23 and above.

Author: nihalgonsalves

.devcontainer/Dockerfile

@@ -1,3 +1,4 @@
-FROM mcr.microsoft.com/devcontainers/javascript-node:20
+FROM mcr.microsoft.com/devcontainers/javascript-node:22
 
+ENV COREPACK_ENABLE_DOWNLOAD_PROMPT=0
 RUN corepack enable

.github/workflows/build.yml

@@ -41,13 +41,3 @@ jobs:
           node -v
           node test.cjs
           node test.mjs
-
-      - uses: actions/setup-node@v4
-        with:
-          node-version: 18
-      - name: test build package on node@18
-        working-directory: ./package-test/
-        run: |
-          node -v
-          node test.cjs
-          node test.mjs

.github/workflows/publish.yml

@@ -36,7 +36,7 @@ jobs:
       - run: corepack enable
       - uses: actions/setup-node@v4
         with:
-          node-version: 20
+          node-version: 22
           registry-url: "https://registry.npmjs.org"
           cache: "yarn"
       - run: yarn install --immutable

.vscode/settings.json

@@ -1,4 +1,5 @@
 {
+  "typescript.tsdk": "node_modules/typescript/lib",
   "editor.formatOnSave": true,
   "editor.defaultFormatter": "esbenp.prettier-vscode",
   "editor.codeActionsOnSave": {

eslint.config.mjs eslint.config.js

@@ -1,5 +1,6 @@
 {
   "name": "esbuild-plugin-browserslist",
+  "type": "module",
   "description": "Configure esbuild's target based on a browserslist query",
   "version": "0.16.0",
   "author": "Nihal Gonsalves <[email protected]>",
@@ -8,10 +9,12 @@
     "url": "https://github.com/nihalgonsalves/esbuild-plugin-browserslist.git"
   },
   "license": "MIT",
-  "main": "./dist/index.js",
-  "types": "./dist/index.d.ts",
+  "exports": {
+    "types": "./dist/index.d.ts",
+    "default": "./dist/index.js"
+  },
   "engines": {
-    "node": ">=18"
+    "node": "^20.19.0 || ^22.12.0 || >23.0.0"
   },
   "files": [
     "dist"

package.json

@@ -1,7 +1,5 @@
 {
   "$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json",
-  "bump-minor-pre-major": true,
-  "bump-patch-for-minor-pre-major": true,
   "bootstrap-sha": "03736f66b1970e7728d40a6b1c53798618f717f3",
   "packages": {
     ".": {

release-please-config.json

@@ -7,7 +7,7 @@ import browserslist from "browserslist";
 import * as esbuild from "esbuild";
 import { vi, describe, it } from "vitest";
 
-import { esbuildPluginBrowserslist } from ".";
+import { esbuildPluginBrowserslist } from "./index.js";
 
 const getFile = async (
   input: string,

src/index.spec.ts

@@ -1,7 +1,7 @@
 import type { Plugin } from "esbuild";
 
-import { resolveToEsbuildTarget as resolveToEsbuildTarget_ } from "./resolveToEsbuildTarget";
-import { dbg, log, PLUGIN_NAME } from "./util";
+import { resolveToEsbuildTarget as resolveToEsbuildTarget_ } from "./resolveToEsbuildTarget.js";
+import { dbg, log, PLUGIN_NAME } from "./util.js";
 
 export type Opts = { printUnknownTargets: boolean };
 

src/index.ts

@@ -1,8 +1,8 @@
 import browserslist from "browserslist";
 import { describe, it } from "vitest";
 
-import { resolveToEsbuildTarget } from "./resolveToEsbuildTarget";
-import { EsbuildEngine } from "./types";
+import { resolveToEsbuildTarget } from "./resolveToEsbuildTarget.js";
+import { EsbuildEngine } from "./types.js";
 
 const useLogs = () => {
   const logs: string[] = [];

src/resolveToEsbuildTarget.spec.ts

@@ -4,8 +4,8 @@ import {
   BrowserslistEsbuildMapping,
   BrowserslistKind,
   type EsbuildEngine,
-} from "./types";
-import { dbg } from "./util";
+} from "./types.js";
+import { dbg } from "./util.js";
 
 const BrowserSchema = z.nativeEnum(BrowserslistKind);
 /** 123 or 123.456 or 123.456.789 */

src/resolveToEsbuildTarget.ts

@@ -1,8 +1,6 @@
 {
   "extends": "./tsconfig.json",
   "compilerOptions": {
-    "module": "NodeNext",
-    "moduleResolution": "NodeNext",
     "declaration": true,
     "noEmit": false,
     "incremental": false,

tsconfig.build.json

@@ -1,9 +1,14 @@
 {
   "extends": "@nihalgonsalves/esconfig/tsconfig.shared.json",
   "compilerOptions": {
+    // https://github.com/microsoft/TypeScript/wiki/Node-Target-Mapping
+    "lib": ["ES2023"],
+    "target": "ES2023",
+    "module": "NodeNext",
+    "moduleResolution": "NodeNext",
     "noEmit": true,
-    "verbatimModuleSyntax": false,
-    "erasableSyntaxOnly": false
+    "erasableSyntaxOnly": false,
+    "types": ["node"]
   },
-  "include": ["src/", "vitest.config.ts", "eslint.config.mjs"]
+  "include": ["src/", "vitest.config.ts", "eslint.config.js"]
 }