Merge pull request #24 from niivue/fix-codesign-macos

Fix codesign macos

Author: hanayik

forge.config.js

@@ -1,30 +1,51 @@
+const osxSign = {
+  identity: process.env.APPLE_IDENTITY // usually looks like: "Developer ID Application: Your Name (XXXXXXXXXX)"
+}
+
+const osxNotarize = {
+  tool: 'notarytool',
+  appleId: process.env.APPLE_ID, // your apple id email address
+  appleIdPassword: process.env.APPLE_APP_PASSWORD, // your app specific password
+  teamId: process.env.APPLE_TEAM_ID // your apple team id (usually the code in parentheses next to your name)
+}
+
+const packagerConfig = {
+  osxSign: osxSign,
+  osxNotarize: osxNotarize,
+  ignore: [
+    /\.git/,
+    /\.vscode/,
+    // do allow minimist, express, and cors
+    // minimist is used to parse command line arguments
+    // express is used to to serve files to niivue 
+    // cors is used to allow cross origin requests (not strictly necessary since this code was taken from another app)
+    /node_modules\/(?!(minimist|express|cors)).*/,
+    /docs/,
+    /dist/,
+    /\.gitignore/,
+    /README\.md/,
+    /LICENSE\.md/
+  ],
+  icon: "./niivue",
+}
+
+// sign and notarise by default, but allow disabling with an environment variable
+// e.g. `NIIVUE_NO_SIGN=1 npm run make:macArm`
+if (process.env.NIIVUE_NO_SIGN === '1') {
+  delete packagerConfig.osxSign
+  // if not signing, then notarization is not possible
+  delete packagerConfig.osxNotarize
+}
+
+// e.g. `NIIVUE_NO_NOTARIZE=1 npm run make:macArm`
+// or both: `NIIVUE_NO_SIGN=1 NIIVUE_NO_NOTARIZE=1 npm run make:macArm`
+if (process.env.NIIVUE_NO_NOTARIZE === '1') {
+  delete packagerConfig.osxNotarize
+}
+
+
 module.exports = {
-  packagerConfig: {
-    // osxSign: {
-    //   identity: process.env.APPLE_IDENTITY
-    // },
-    // osxNotarize: {
-    //   tool: 'notarytool',
-    //   appleApiKey: process.env.APPLE_API_KEY,
-    //   appleApiKeyId: process.env.APPLE_API_KEY_ID,
-    //   appleApiIssuer: process.env.APPLE_API_ISSUER
-    // },
-    ignore: [
-      /\.git/,
-      /\.vscode/,
-      // do allow minimist, express, and cors
-      // minimist is used to parse command line arguments
-      // express is used to to serve files to niivue 
-      // cors is used to allow cross origin requests (not strictly necessary since this code was taken from another app)
-      /node_modules\/(?!(minimist|express|cors)).*/,
-      /docs/,
-      /dist/,
-      /\.gitignore/,
-      /README\.md/,
-      /LICENSE\.md/
-    ],
-    icon: "./niivue",
-  },
+  packagerConfig: packagerConfig,
   rebuildConfig: {},
   makers: [
     {

package-lock.json

@@ -1,7 +1,7 @@
 {
   "name": "niivue-desktop",
-  "productName": "NiiVue",
-  "version": "0.2.0",
+  "productName": "Niivue",
+  "version": "0.2.1",
   "description": "A medical image viewer with a focus on neuroimaging",
   "main": "src/electron/index.js",
   "scripts": {