Skip to content

Commit 9a9f2da

Browse files
committed
style(board): correct svelte lint warnings
1 parent 7dc7faa commit 9a9f2da

File tree

6 files changed

+17
-17
lines changed

6 files changed

+17
-17
lines changed

packages/board/src/BoardFilter.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -370,7 +370,7 @@
370370

371371
{#if focussed && value && match}
372372
<div class="help-dropdown">
373-
{#each match.categories as category, idx}
373+
{#each match.categories as category, idx (category)}
374374
{#if idx > 0}
375375
<hr />
376376
{/if}

packages/board/src/Card.svelte

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -179,13 +179,13 @@
179179
/>
180180
{/if}
181181

182-
{#each labels as { name, color }}
182+
{#each labels as label (label.name)}
183183
<Tag
184184
clazz="tag label"
185-
color="#{ color }"
186-
name={ name }
187-
title={ name }
188-
onclick={ handleSelection('label', name) }
185+
color="#{ label.color }"
186+
name={ label.name }
187+
title={ label.name }
188+
onclick={ handleSelection('label', label.name) }
189189
/>
190190
{/each}
191191

@@ -200,7 +200,7 @@
200200

201201
{#if shownLinks.length}
202202
<div class="board-card-links embedded">
203-
{#each shownLinks as link}
203+
{#each shownLinks as link (link)}
204204
<CardLink item={ link.target } type={ link.type } ref={ link.ref } onSelect={ onSelect } />
205205
{/each}
206206
</div>
@@ -211,7 +211,7 @@
211211

212212
{#if prLinks.length}
213213
<div class="board-card-links attached">
214-
{#each prLinks as link}
214+
{#each prLinks as link (link)}
215215
<CardLink item={ link.target } type={ link.type } ref={ link.ref } onSelect={ onSelect }>
216216
<CardStatus item={ link.target } />
217217
</CardLink>

packages/board/src/CardStatus.svelte

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
{#if check_runs.length || statuses.length}
1919
<div class="card-status">
2020

21-
{#each check_runs as check_run}
21+
{#each check_runs as check_run (check_run)}
2222
<a
2323
class="state"
2424
class:success={ check_run.conclusion === 'success' || check_run.status === 'in_progress' }
@@ -32,7 +32,7 @@
3232
><span>{check_run.name} — {check_run_result_map[check_run.conclusion] || check_run_result_map[check_run.status] }</span></a>
3333
{/each}
3434

35-
{#each statuses as status}
35+
{#each statuses as status (status)}
3636
<a
3737
class="state"
3838
class:success={ status.state === 'success' || status.state === 'pending' }

packages/board/src/CollaboratorLinks.svelte

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@
8181
}
8282
</script>
8383

84-
{#each requested_reviewers as reviewer}
84+
{#each requested_reviewers as reviewer (reviewer)}
8585
<a
8686
class="assignee requested-reviewer"
8787
title="{ reviewer.login } requested for review"
@@ -94,7 +94,7 @@
9494
</a>
9595
{/each}
9696

97-
{#each reviews as review}
97+
{#each reviews as review (review)}
9898
<a
9999
class="assignee reviewer"
100100
class:approved={ review.state === 'approved' }
@@ -111,7 +111,7 @@
111111
</a>
112112
{/each}
113113

114-
{#each assignees as assignee}
114+
{#each assignees as assignee (assignee.login)}
115115
<a
116116
class="assignee"
117117
title="{ assignee.login } assigned"

packages/board/src/Taskboard.svelte

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -827,7 +827,7 @@
827827

828828
<Notifications>
829829
{#if !error}
830-
{#each warnings as warning}
830+
{#each warnings as warning (warning)}
831831
<Notification type="warning" message="{ warning.action } failed">
832832
Could not reach the board back-end. <a href>Reload board.</a>
833833
</Notification>
@@ -863,7 +863,7 @@
863863
value={ filter }
864864
completionOptions={ filterOptions }
865865
onChange={ filterChanged }
866-
placeholder={ 'Filter board...' }
866+
placeholder="Filter board..."
867867
/>
868868
</form>
869869

@@ -894,7 +894,7 @@
894894
<main class="taskboard-board scroll-container-h">
895895

896896
{#if !error}
897-
{#each columns as column }
897+
{#each columns as column(column.name)}
898898
<div class="taskboard-column" class:collapsed={ collapsed[column.name] }>
899899
<div class="taskboard-column-header">
900900
<button

packages/board/src/components/HintList.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949
onmousedown={ (e) => handleMousedown(e, hint) }
5050
onclick={ (e) => e.preventDefault() || handleMousedown(e, hint) }
5151
href
52-
>{#each hint.parts as part}<span class:matched={ part.matched }>{ part.text }</span>{/each}</a>
52+
>{#each hint.parts as part (part.text)}<span class:matched={ part.matched }>{ part.text }</span>{/each}</a>
5353
</li>
5454
{/each}
5555
</ul>

0 commit comments

Comments
 (0)