fix(sidecar): sweep stale p2p key references from comments and specs

The kv_transfer_params nesting key is remote_kv_source; comments and test
descriptions that still call it the p2p key or p2p params read as if the
secondary-tier type (p2p, unchanged) were the request-field key.

Signed-off-by: nilig <nili.ifergan@gmail.com>

Author: nilig

pkg/sidecar/proxy/connector_nixlv2_p2p_test.go

@@ -103,7 +103,7 @@ var _ = Describe("NIXL Connector with P2P pull", func() {
 		// NIXL fields still drive the NixlConnector under MultiConnector.
 		Expect(kv).To(HaveKeyWithValue(requestFieldDoRemoteDecode, true))
 		Expect(kv).To(HaveKeyWithValue(requestFieldDoRemotePrefill, false))
-		// The p2p block drives the OffloadingConnector's cached-prefix pull.
+		// The remote_kv_source block drives the OffloadingConnector's cached-prefix pull.
 		p2p, ok := kv[requestFieldP2PParams].(map[string]any)
 		Expect(ok).To(BeTrue())
 		Expect(p2p[requestFieldKVRequestID]).ToNot(BeEmpty())
@@ -157,7 +157,7 @@ var _ = Describe("NIXL Connector with P2P pull", func() {
 		body, _ := io.ReadAll(resp.Body) //nolint:errcheck
 		Expect(resp.StatusCode).To(Equal(http.StatusOK), string(body))
 
-		// Prefill leg keeps the NIXL WRITE fields and gains the composed p2p block.
+		// Prefill leg keeps the NIXL WRITE fields and gains the composed remote_kv_source block.
 		pkv := kvParams(env.prefillHandler, 0)
 		Expect(pkv).To(HaveKeyWithValue(requestFieldDoRemoteDecode, true))
 		p2p, ok := pkv[requestFieldP2PParams].(map[string]any)

pkg/sidecar/proxy/connector_p2p.go

@@ -213,19 +213,20 @@ func (s *Server) handleP2PConcurrentRequests(w http.ResponseWriter, r *http.Requ
 // KVConnector is offloading, or is composed alongside NIXL via MultiConnector
 // (declared with --enable-p2p-pull) when the PD connector is NIXLv2. On any
 // other connector --enable-p2p-pull has no effect, since no MultiConnector
-// routes the p2p params to an OffloadingConnector.
+// routes the remote_kv_source params to an OffloadingConnector.
 func (s *Server) p2pPullAvailable() bool {
 	return s.config.KVConnector == KVConnectorOffloading ||
 		(s.config.EnableP2PPull && s.config.KVConnector == KVConnectorNIXLV2)
 }
 
-// addP2PPullToPrefill adds the OffloadingConnector p2p pull block to a prefill
+// addP2PPullToPrefill adds the OffloadingConnector P2P pull block to a prefill
 // leg's kv_transfer_params so the prefiller pulls cached prefix from
 // kvCacheSource while keeping its own computed blocks available for the
 // decoder. It is a no-op when no source is set or the source resolves to the
-// prefiller itself, since there is nothing to pull from oneself. The p2p key
-// composes with NIXL params: vLLM's MultiConnector routes it to the
-// OffloadingConnector and the NIXL fields to the NixlConnector.
+// prefiller itself, since there is nothing to pull from oneself. The
+// remote_kv_source key composes with NIXL params: vLLM's MultiConnector
+// routes it to the OffloadingConnector and the NIXL fields to the
+// NixlConnector.
 func (s *Server) addP2PPullToPrefill(prefillKVParams map[string]any, kvCacheSource, prefillPodHostPort string) {
 	if kvCacheSource != "" && extractHost(kvCacheSource) != extractHost(prefillPodHostPort) {
 		prefillKVParams[requestFieldP2PParams] = s.p2pSourceParams(kvCacheSource)

pkg/sidecar/proxy/connector_p2p_source_test.go

@@ -73,7 +73,7 @@ var _ = Describe("P2P KV cache source header", func() {
 		return sendBody(proxyBaseAddr, chatCompletionsRequestBodyWithMaxCompletionTokens, headers)
 	}
 
-	It("should inject p2p params on the local request without disaggregation", func() {
+	It("should inject remote_kv_source params on the local request without disaggregation", func() {
 		proxyBaseAddr := testInfo.startProxy()
 
 		sendRequest(proxyBaseAddr, map[string]string{routing.KVCacheSourceHeader: kvCacheSource})
@@ -99,7 +99,7 @@ var _ = Describe("P2P KV cache source header", func() {
 		<-testInfo.stoppedCh
 	})
 
-	It("should add p2p params to the prefill leg under disaggregation", func() {
+	It("should add remote_kv_source params to the prefill leg under disaggregation", func() {
 		proxyBaseAddr := testInfo.startProxy()
 
 		prefillHostPort := testInfo.prefillBackend.URL[len("http://"):]
@@ -162,7 +162,7 @@ var _ = Describe("P2P KV cache source header", func() {
 		<-testInfo.stoppedCh
 	})
 
-	It("should not inject p2p params without the header", func() {
+	It("should not inject remote_kv_source params without the header", func() {
 		proxyBaseAddr := testInfo.startProxy()
 
 		sendRequest(proxyBaseAddr, nil)
@@ -198,7 +198,7 @@ var _ = Describe("P2P KV cache source header", func() {
 		Expect(decodeReqs).To(HaveLen(1))
 		kvParams, ok := decodeReqs[0][requestFieldKVTransferParams].(map[string]any)
 		Expect(ok).To(BeTrue())
-		// Only the sidecar-owned p2p key survives; the client's keys are gone.
+		// Only the sidecar-owned remote_kv_source key survives; the client's keys are gone.
 		Expect(kvParams).To(HaveLen(1))
 		p2p, ok := kvParams[requestFieldP2PParams].(map[string]any)
 		Expect(ok).To(BeTrue())
@@ -221,7 +221,7 @@ var _ = Describe("P2P KV cache source header", func() {
 		<-testInfo.stoppedCh
 	})
 
-	It("should not inject p2p params when the source is the local pod", func() {
+	It("should not inject remote_kv_source params when the source is the local pod", func() {
 		GinkgoT().Setenv("POD_IP", "10.9.9.9")
 		proxyBaseAddr := testInfo.startProxy()