Skip to content

Commit a681071

Browse files
committed
chore(sidecar): log P2P rank-derivation fallbacks at debug
The fallbacks in p2pPortFor silently return the base P2P port, so a misrouted or unparsable target is invisible in the logs; a debug line per fallback explains which guard fired. Signed-off-by: nilig <nili.ifergan@gmail.com>
1 parent 47af661 commit a681071

1 file changed

Lines changed: 7 additions & 0 deletions

File tree

pkg/sidecar/proxy/connector_p2p.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -269,14 +269,21 @@ func (s *Server) p2pPortFor(targetHostPort string) int {
269269
targetHostPort, _ = strings.CutPrefix(targetHostPort, "http://")
270270
_, portStr, err := net.SplitHostPort(targetHostPort)
271271
if err != nil {
272+
s.logger.V(logging.DEBUG).Info("P2P target has no parsable port, using base P2P port",
273+
"target", targetHostPort, "error", err)
272274
return base
273275
}
274276
port, err := strconv.Atoi(portStr)
275277
if err != nil {
278+
s.logger.V(logging.DEBUG).Info("P2P target port is not numeric, using base P2P port",
279+
"target", targetHostPort, "error", err)
276280
return base
277281
}
278282
rank := port - s.dpBasePort
279283
if rank < 0 || rank >= s.config.DataParallelSize {
284+
s.logger.V(logging.DEBUG).Info("P2P target port outside the DP rank range, using base P2P port",
285+
"target", targetHostPort, "dpBasePort", s.dpBasePort,
286+
"dataParallelSize", s.config.DataParallelSize)
280287
return base
281288
}
282289
return base + rank

0 commit comments

Comments
 (0)