Skip to content

Commit d943d01

Browse files
committed
findings: #48021 merged 2026-07-26T08:45:48Z, correct baseline framing
#48021 merged into vllm-project/vllm main during this session (discovered while verifying a Codex correction on the PR #49877 review comment). Confirmed via matching git blob SHAs that the P2P tier content tested all session (Liran's 4a210582 snapshot) is byte-identical to what actually merged (da3a252fd) -- no re-validation needed, only re-description. Also tightened 'exactly #49877's actual base' framing to 'integration baseline' with exact commit hashes, since the PR's real git base (main) now contains #48021 directly, while what was tested was a hand-assembled overlay on a pre-merge nightly. Signed-off-by: nilig <nili.ifergan@gmail.com>
1 parent e500666 commit d943d01

1 file changed

Lines changed: 14 additions & 9 deletions

File tree

test/p2p-findings/upstream-issues-map.md

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ directly on GitHub.
1515
| [#49809](https://github.com/vllm-project/vllm/issues/49809) | reconnect to a reaped peer trips `AssertionError: ZmqConnection already exists`; dead conn never released | P2P control transport (`tiering/p2p/control/zmq.py`) | crash | pd-defects Defect 2 | [#49823](https://github.com/vllm-project/vllm/pull/49823) open, validated (5 fail stock / 16 pass patched), our review comment posted on the PR directly |
1616
| [#49820](https://github.com/vllm-project/vllm/issues/49820) | symmetric producer accepts a fetch it cannot serve, never sends `TransferDone(success=False)` -> consumer deferred full `_LOAD_TIMEOUT_S=30s`. ROOT CAUSE FOUND 2026-07-26 -- see below | P2P session (`tiering/p2p/session/*`) | stall | new (post-Liran residual) | [#49877](https://github.com/vllm-project/vllm/pull/49877) open, VALIDATED at 3 levels incl. our own GPU repro -- works end-to-end, 1 narrower gap remains -- see below |
1717
| [#49829](https://github.com/vllm-project/vllm/issues/49829) | `TieringOffloadingManager.lookup()` returns `HIT_PENDING` unconditionally, no deadline, no downgrade-to-MISS | shared tiering manager (`tiering/manager.py`) -- NOT P2P-specific | stall | lookup-hangs Defect 3 | [#49850](https://github.com/vllm-project/vllm/pull/49850) DRAFT (author flags end-to-end/scale validation as pending); we validated unit-level and posted 2 confirmed review findings -- see below |
18-
| -- | the generic/symmetric P2P secondary tier itself (peer lookup + serving via `ParentManager`) -- the tier all four bugs above exercise | P2P tier, foundational | -- | -- | [#48021](https://github.com/vllm-project/vllm/pull/48021) open, APPROVED by orozery 2026-07-22, not yet merged (contains the one-fetch contract fixing lookup-hangs Defect 1+2) |
18+
| -- | the generic/symmetric P2P secondary tier itself (peer lookup + serving via `ParentManager`) -- the tier all four bugs above exercise | P2P tier, foundational | -- | -- | [#48021](https://github.com/vllm-project/vllm/pull/48021) **MERGED** 2026-07-26T08:45:48Z by orozery (`da3a252fd13f51c22657bfc8650936f2fbb5b6f3`; contains the one-fetch contract fixing lookup-hangs Defect 1+2) |
1919

2020
Distinguishing axis: #49635 and #49829 are OffloadingConnector-general (fire
2121
even aggregated / no P2P, different files from each other); #49809 and #49820
@@ -111,12 +111,15 @@ on main).
111111
**Validated at 3 levels, not just trusted from the PR description:**
112112

113113
1. **Their own test suite, run by us.** Baseline = our `combined_overlay`
114-
(exactly #48021's current head + #49823, i.e. #49877's actual base --
115-
NOT stock nightly, which is missing #48021's `LookupMsg`/`LookupRespMsg`
116-
protocol additions entirely). `test_issue_49820_repro.py`: 8/8 FAIL on
117-
baseline. Full `tests/v1/kv_offload/tiering/p2p/` with #49877's
118-
manager.py/client.py/server.py swapped in: **209/209 PASS**, exact match
119-
to the claimed count.
114+
integration baseline: nightly-1240c74c (predates #48021's merge) with
115+
#48021 overlaid at `4a210582` (confirmed byte-identical to the merged
116+
`da3a252fd`) + #49823 overlaid at `ba6425e2` -- NOT stock nightly, which
117+
is missing #48021's `LookupMsg`/`LookupRespMsg` protocol additions
118+
entirely. `test_issue_49820_repro.py`: 8/8 FAIL on baseline. Full
119+
`tests/v1/kv_offload/tiering/p2p/` with #49877's manager.py/client.py/
120+
server.py swapped in: **209/209 PASS**, exact match to the claimed count.
121+
NOTE: #48021 MERGED 2026-07-26T08:45:48Z, after this session's testing
122+
began -- confirmed no re-validation needed (file content identical).
120123

121124
2. **A new, narrower regression we wrote and ran** (`scratchpad/
122125
repro_49877_finish_gap.py`), surfacing one remaining gap: `ClientRole.
@@ -197,8 +200,10 @@ Two catalogs both start at "Defect 1", causing collisions:
197200

198201
One crash resolved (#49635, via merged #49671); one crash has an open,
199202
validated fix PR pending merge (#49809 -> #49823, our review comment posted
200-
directly on the PR); lookup-hangs Defect 1+2 covered by #48021 (open,
201-
APPROVED, not yet merged). Both remaining stalls trace to the same design
203+
directly on the PR); lookup-hangs Defect 1+2 covered by #48021, which
204+
**MERGED 2026-07-26T08:45:48Z** (confirmed the P2P tier files tested all
205+
session are byte-identical to what actually merged, so nothing needs
206+
re-validating). Both remaining stalls trace to the same design
202207
gap -- no round/generation identifier for multi-round P2P promotions under
203208
one `kv_request_id` (see "Root causes resolved" above). #49820 now has an
204209
open fix PR (#49877) VALIDATED at 3 levels including our own independent GPU

0 commit comments

Comments
 (0)