Improvements towards supporting big packages (nwaku) (#1532)

* Add PackageNotFoundError for specific error handling

- Add PackageNotFoundError exception type in common.nim
- Use PackageNotFoundError in download.nim when package is not found
- Catch PackageNotFoundError instead of CatchableError in nimblesat.nim
  validation to only skip versions for truly missing packages

* Fix git checkout for version tags with v prefix

Some packages use 'v' prefixed tags (e.g., v0.1.0) while the version
in nimble is without prefix (0.1.0). When checkout fails, try again
with 'v' prefix as fallback.

* Prefer tagged releases over HEAD revision

Add specialized addUnique for PackageMinimalInfo that compares by
name and version only. This ensures when multiple nimble file
revisions exist for the same version tag, we keep the first one.

Change processing order in getPackageMinimalVersionsFromRepo and
getPackageMinimalVersionsFromRepoAsync to:
1. Process tagged versions first (added to result)
2. Add HEAD version last using addUnique

This ensures tagged releases take precedence over HEAD when both
have the same version, providing more reliable package metadata.

* Move updateSubmodules outside of the cache. Its faster and more reliable
(old pkgs may trigger potential errors)

* Improves SAT solver so it process versions on ascending order. Adds
version discovery option

* Some installation fixes.

* Adds a tests that proofs that waku's deps can be solved

* Fixes CI test

Author: jmgomez

src/nimblepkg/common.nim

@@ -13,6 +13,9 @@ type
 
   BuildFailed* = object of NimbleError
 
+  PackageNotFoundError* = object of NimbleError
+    ## Raised when a package cannot be found in any repository
+
   ## Same as quit(QuitSuccess) or quit(QuitFailure), but allows cleanup.
   ## Inheriting from `Defect` is workaround to avoid accidental catching of
   ## `NimbleQuit` by `CatchableError` handlers.

src/nimblepkg/download.nim

@@ -15,7 +15,10 @@ type
     version: Version
     vcsRevision: Sha1Hash
 
-proc updateSubmodules(dir: string) =
+proc updateSubmodules*(dir: string) =
+  ## Updates git submodules in the given directory.
+  ## Called during installation to ensure submodules are populated
+  ## even if the package was cached without them during version discovery.
   discard tryDoCmdEx(
     &"git -C {dir.quoteShell} submodule update --init --recursive --depth 1")
 
@@ -37,7 +40,10 @@ proc doCheckout*(meth: DownloadMethod, downloadDir, branch: string, options: Opt
     # Force is used here because local changes may appear straight after a clone
     # has happened. Like in the case of git on Windows where it messes up the
     # damn line endings.
-    discard tryDoCmdEx(&"git -C {downloadDir.quoteShell} checkout --force {branch.quoteShell}")
+    let (_, exitCode) = doCmdEx(&"git -C {downloadDir.quoteShell} checkout --force {branch.quoteShell}")
+    if exitCode != 0 and not branch.startsWith("v"):
+      # Try with 'v' prefix as fallback (common convention for version tags)
+      discard tryDoCmdEx(&"git -C {downloadDir.quoteShell} checkout --force v{branch.quoteShell}")
     if not options.ignoreSubmodules:
       downloadDir.updateSubmodules
   of DownloadMethod.hg:
@@ -50,7 +56,10 @@ proc doCheckoutAsync*(meth: DownloadMethod, downloadDir, branch: string, options
     # Force is used here because local changes may appear straight after a clone
     # has happened. Like in the case of git on Windows where it messes up the
     # damn line endings.
-    discard await tryDoCmdExAsync(&"git -C {downloadDir.quoteShell} checkout --force {branch.quoteShell}")
+    let (_, exitCode) = await doCmdExAsync(&"git -C {downloadDir.quoteShell} checkout --force {branch.quoteShell}")
+    if exitCode != 0 and not branch.startsWith("v"):
+      # Try with 'v' prefix as fallback (common convention for version tags)
+      discard await tryDoCmdExAsync(&"git -C {downloadDir.quoteShell} checkout --force v{branch.quoteShell}")
     if not options.ignoreSubmodules:
       await downloadDir.updateSubmodulesAsync()
   of DownloadMethod.hg:
@@ -1046,7 +1055,7 @@ proc getDownloadInfo*(
       # Also ignore the package cache so the old info isn't used
       return getDownloadInfo(pv, options, false, true)
     else:
-      raise nimbleError(pkgNotFoundMsg(pv))
+      raise newNimbleError[PackageNotFoundError](pkgNotFoundMsg(pv))
 
 when isMainModule:
   import unittest